fix: move 02-client legacy v1beta gov types deprecation message to constructor functions #5837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
colin-axner
approved these changes
Feb 14, 2024
chatton
approved these changes
Feb 14, 2024
crodriguezvega
deleted the
carlos/move-deprecation-message-to-constructor-functions
branch
|
🙏🏻 |
|
shall we backport this one to |
We can backport to v8.2.x and release v8.2.1, since all previous versions of v8.x have been retracted due to ASA-2024-007. Would this work for you? |
yeah, 8.2 is perfect. |
mergify bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> (cherry picked from commit 531cff9)
mergify bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> (cherry picked from commit 531cff9)
crodriguezvega
added a commit
that referenced
this pull request
Apr 11, 2024
…nstructor functions (backport #5837) (#6140) * fix: move deprecation message to constructor functions (#5837) Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> (cherry picked from commit 531cff9) * Update CHANGELOG.md --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
crodriguezvega
added a commit
that referenced
this pull request
Apr 11, 2024
|
@yihuang The v8.2.1 release with this fix now available: https://github.com/cosmos/ibc-go/releases/tag/v8.2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.