-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: remove 24-host path function in favour of sybling key functions (backport #7016) #7034
Conversation
Cherry-pick of f4eba71 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
note, took liberty of completely dropping docs folder instead of fixing conflicts there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing docs breaks markdown links, but we shouldn't be linking from the release branch anyways
Thanks for picking this up @DimitrisJim ! |
yup, let me just drop that too. we shouldn't have it in release branches. |
|
Description
closes: #6882
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.This is an automatic backport of pull request #7016 done by [Mergify](https://mergify.com).