Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: accidental change of consensus height to pointer #7130

Merged
merged 2 commits into from
Aug 13, 2024
Merged

revert: accidental change of consensus height to pointer #7130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52a302f
revert: accidental change of consensus height to pointer
colin-axner Aug 12, 2024
50047f1
Merge branch 'main' into colin/revert-accidental-change
colin-axner Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
182 changes: 84 additions & 98 deletions modules/core/03-connection/types/tx.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions proto/ibc/core/connection/v1/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ message MsgConnectionOpenTry {
// Deprecated: this field is unused.
bytes proof_consensus = 10 [deprecated = true];
// Deprecated: this field is unused.
ibc.core.client.v1.Height consensus_height = 11 [deprecated = true];
ibc.core.client.v1.Height consensus_height = 11 [deprecated = true, (gogoproto.nullable) = false];
string signer = 12;
// Deprecated: this field is unused.
bytes host_consensus_state_proof = 13 [deprecated = true];
Expand Down Expand Up @@ -104,7 +104,7 @@ message MsgConnectionOpenAck {
// Deprecated: this field is unused.
bytes proof_consensus = 8 [deprecated = true];
// Deprecated: this field is unused.
ibc.core.client.v1.Height consensus_height = 9 [deprecated = true];
ibc.core.client.v1.Height consensus_height = 9 [deprecated = true, (gogoproto.nullable) = false];
string signer = 10;
// Deprecated: this field is unused.
bytes host_consensus_state_proof = 11 [deprecated = true];
Expand Down
Loading