Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: no longer removing active channel mapping on close channel #730

Merged
merged 10 commits into from
Jan 14, 2022
Merged

refactor: no longer removing active channel mapping on close channel #730

merged 10 commits into from
Jan 14, 2022

Commits on Jan 13, 2022

  1. refactor: no longer remove active channel mapping on close chan

    @seantking
    seantking committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    baa5d9d View commit details
    Browse the repository at this point in the history

  2. refactor: adding HasActiveChannel helper fn & refactor active channel… 

    … test cases
    @seantking
    seantking committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    3ac112e View commit details
    Browse the repository at this point in the history

  3. fix: update helper fn

    @seantking
    seantking committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    c467787 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into sean/issue#-707-do-not-delete-active-channel

    @seantking
    seantking authored Jan 13, 2022
    Configuration menu
    Copy the full SHA
    1fdaa3f View commit details
    Browse the repository at this point in the history

  5. refactor: remove DeleteChannelId

    @seantking
    seantking committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    5f28a1f View commit details
    Browse the repository at this point in the history

  6. refactor: err on GetActiveChannel & use TestVersion var in use testcase

    @seantking
    seantking committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    b40f329 View commit details
    Browse the repository at this point in the history

  7. chore: comments

    @seantking
    seantking committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    ba5cafa View commit details
    Browse the repository at this point in the history

  8. nit: TestVersion var

    @seantking
    seantking committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    38c05d9 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2022

  1. nits: fn name + comment

    @seantking
    seantking committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    7161674 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into sean/issue#-707-do-not-delete-active-channel

    @seantking
    seantking authored Jan 14, 2022
    Configuration menu
    Copy the full SHA
    edd267a View commit details
    Browse the repository at this point in the history