Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding implementation for SendPacket message server #7383

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: merge feature branch
chatton committed Oct 3, 2024
commit cfa2a3ded3449355a3f959f2d2ff367ea83691a6
5 changes: 4 additions & 1 deletion modules/core/04-channel/v2/keeper/msg_server.go
Original file line number Diff line number Diff line change
@@ -2,7 +2,6 @@

import (
"context"

errorsmod "cosmossdk.io/errors"

sdk "github.com/cosmos/cosmos-sdk/types"
@@ -42,12 +41,16 @@
return &channeltypesv2.MsgSendPacketResponse{Sequence: sequence}, nil
}

func (k Keeper) Acknowledgement(ctx context.Context, acknowledgement *channeltypesv2.MsgAcknowledgement) (*channeltypesv2.MsgAcknowledgementResponse, error) {

Check failure on line 44 in modules/core/04-channel/v2/keeper/msg_server.go

GitHub Actions / lint

unused-receiver: method receiver 'k' is not referenced in method's body, consider removing or renaming it as _ (revive)

Check failure on line 44 in modules/core/04-channel/v2/keeper/msg_server.go

GitHub Actions / lint

unused-receiver: method receiver 'k' is not referenced in method's body, consider removing or renaming it as _ (revive)
panic("implement me")
}

// RecvPacket implements the PacketMsgServer RecvPacket method.
func (k *Keeper) RecvPacket(ctx context.Context, packet *channeltypesv2.MsgRecvPacket) (*channeltypesv2.MsgRecvPacketResponse, error) {

Check failure on line 49 in modules/core/04-channel/v2/keeper/msg_server.go

GitHub Actions / lint

unused-receiver: method receiver 'k' is not referenced in method's body, consider removing or renaming it as _ (revive)

Check failure on line 49 in modules/core/04-channel/v2/keeper/msg_server.go

GitHub Actions / lint

unused-receiver: method receiver 'k' is not referenced in method's body, consider removing or renaming it as _ (revive)
panic("implement me")
}

// Timeout implements the PacketMsgServer Timeout method.
func (k *Keeper) Timeout(ctx context.Context, timeout *channeltypesv2.MsgTimeout) (*channeltypesv2.MsgTimeoutResponse, error) {

Check failure on line 54 in modules/core/04-channel/v2/keeper/msg_server.go

GitHub Actions / lint

unused-receiver: method receiver 'k' is not referenced in method's body, consider removing or renaming it as _ (revive)

Check failure on line 54 in modules/core/04-channel/v2/keeper/msg_server.go

GitHub Actions / lint

unused-receiver: method receiver 'k' is not referenced in method's body, consider removing or renaming it as _ (revive)
panic("implement me")
}
16 changes: 0 additions & 16 deletions modules/core/04-channel/v2/types/channel.go

This file was deleted.

2 changes: 2 additions & 0 deletions modules/core/04-channel/v2/types/errors.go
Original file line number Diff line number Diff line change
@@ -7,4 +7,6 @@ import (
var (
ErrInvalidCounterparty = errorsmod.Register(SubModuleName, 1, "invalid counterparty")
ErrCounterpartyNotFound = errorsmod.Register(SubModuleName, 2, "counterparty not found")
ErrInvalidPacket = errorsmod.Register(SubModuleName, 3, "invalid packet")
ErrInvalidPayload = errorsmod.Register(SubModuleName, 4, "invalid payload")
)

Unchanged files with check annotations Beta

}
destID := counterparty.CounterpartyChannelId
clientId := counterparty.ClientId

Check failure on line 41 in modules/core/04-channel/v2/keeper/relay.go

GitHub Actions / lint

var-naming: var clientId should be clientID (revive)

Check failure on line 41 in modules/core/04-channel/v2/keeper/relay.go

GitHub Actions / lint

var-naming: var clientId should be clientID (revive)
// retrieve the sequence send for this channel
// if no packets have been sent yet, initialize the sequence to 1.
You are viewing a condensed version of this merge commit. You can view the full changes here.