Implement MsgSendPacket RPC handler and tests #7413
+192
−51
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| package keeper_test | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
|
|
||
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
|
|
||
| clienttypes "github.com/cosmos/ibc-go/v9/modules/core/02-client/types" | ||
| channeltypesv1 "github.com/cosmos/ibc-go/v9/modules/core/04-channel/types" | ||
| channeltypesv2 "github.com/cosmos/ibc-go/v9/modules/core/04-channel/v2/types" | ||
| ibctesting "github.com/cosmos/ibc-go/v9/testing" | ||
| "github.com/cosmos/ibc-go/v9/testing/mock" | ||
| mockv2 "github.com/cosmos/ibc-go/v9/testing/mock/v2" | ||
| ) | ||
|
|
||
| func (suite *KeeperTestSuite) TestMsgSendPacket() { | ||
| var ( | ||
| path *ibctesting.Path | ||
| msg *channeltypesv2.MsgSendPacket | ||
| expectedPacket channeltypesv2.Packet | ||
| ) | ||
|
|
||
| testCases := []struct { | ||
| name string | ||
| malleate func() | ||
| expError error | ||
| }{ | ||
| { | ||
| name: "success", | ||
| malleate: func() {}, | ||
| expError: nil, | ||
| }, | ||
| { | ||
| name: "failure: timeout elapsed", | ||
| malleate: func() { | ||
| // ensure a message timeout. | ||
| msg.TimeoutTimestamp = uint64(1) | ||
| }, | ||
| expError: channeltypesv1.ErrTimeoutElapsed, | ||
| }, | ||
| { | ||
| name: "failure: inactive client", | ||
| malleate: func() { | ||
| path.EndpointA.FreezeClient() | ||
| }, | ||
| expError: clienttypes.ErrClientNotActive, | ||
| }, | ||
| { | ||
| name: "failure: application callback error", | ||
| malleate: func() { | ||
| path.EndpointA.Chain.GetSimApp().MockModuleV2A.IBCApp.OnSendPacket = func(ctx context.Context, sourceID string, destinationID string, sequence uint64, data channeltypesv2.PacketData, signer sdk.AccAddress) error { | ||
| return mock.MockApplicationCallbackError | ||
| } | ||
| }, | ||
| expError: mock.MockApplicationCallbackError, | ||
| }, | ||
| { | ||
| name: "failure: counterparty not found", | ||
| malleate: func() { | ||
| msg.SourceChannel = "foo" | ||
| }, | ||
| expError: channeltypesv1.ErrChannelNotFound, | ||
| }, | ||
| { | ||
| name: "failure: route to non existing app", | ||
| malleate: func() { | ||
| msg.PacketData[0].SourcePort = "foo" | ||
| }, | ||
| expError: fmt.Errorf("no route for foo"), | ||
| }, | ||
| } | ||
|
|
||
| for _, tc := range testCases { | ||
| tc := tc | ||
|
|
||
| suite.Run(tc.name, func() { | ||
| suite.SetupTest() // reset | ||
|
|
||
| path = ibctesting.NewPath(suite.chainA, suite.chainB) | ||
| path.SetupV2() | ||
|
|
||
| timeoutTimestamp := suite.chainA.GetTimeoutTimestamp() | ||
| msg = channeltypesv2.NewMsgSendPacket(path.EndpointA.ChannelID, timeoutTimestamp, suite.chainA.SenderAccount.GetAddress().String(), mockv2.NewMockPacketData(mockv2.ModuleNameA, mockv2.ModuleNameB)) | ||
|
|
||
| expectedPacket = channeltypesv2.NewPacket(1, path.EndpointA.ChannelID, path.EndpointB.ChannelID, timeoutTimestamp, mockv2.NewMockPacketData(mockv2.ModuleNameA, mockv2.ModuleNameB)) | ||
|
|
||
| tc.malleate() | ||
|
|
||
| res, err := path.EndpointA.Chain.SendMsgs(msg) | ||
|
|
||
| expPass := tc.expError == nil | ||
| if expPass { | ||
| suite.Require().NoError(err) | ||
| suite.Require().NotNil(res) | ||
|
|
||
| ck := path.EndpointA.Chain.GetSimApp().IBCKeeper.ChannelKeeperV2 | ||
|
|
||
| packetCommitment := ck.GetPacketCommitment(path.EndpointA.Chain.GetContext(), path.EndpointA.ChannelID, 1) | ||
| suite.Require().NotNil(packetCommitment) | ||
| suite.Require().Equal(channeltypesv2.CommitPacket(expectedPacket), packetCommitment, "packet commitment is not stored correctly") | ||
|
|
||
| nextSequenceSend, ok := ck.GetNextSequenceSend(path.EndpointA.Chain.GetContext(), path.EndpointA.ChannelID) | ||
| suite.Require().True(ok) | ||
| suite.Require().Equal(uint64(2), nextSequenceSend, "next sequence send was not incremented correctly") | ||
|
|
||
| } else { | ||
| suite.Require().Error(err) | ||
| ibctesting.RequireErrorIsOrContains(suite.T(), err, tc.expError) | ||
| } | ||
| }) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package types | ||
|
|
||
| // NewMsgSendPacket creates a new MsgSendPacket instance. | ||
| func NewMsgSendPacket(sourceChannel string, timeoutTimestamp uint64, signer string, packetData ...PacketData) *MsgSendPacket { | ||
| return &MsgSendPacket{ | ||
| SourceChannel: sourceChannel, | ||
| TimeoutTimestamp: timeoutTimestamp, | ||
| PacketData: packetData, | ||
| Signer: signer, | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,22 @@ | ||
| package mock | ||
|
|
||
| import ( | ||
| "github.com/cosmos/ibc-go/v9/modules/core/04-channel/v2/types" | ||
| "github.com/cosmos/ibc-go/v9/testing/mock" | ||
| ) | ||
|
|
||
| const ( | ||
| ModuleName = "mockv2" | ||
| ) | ||
|
|
||
| func NewMockPacketData(sourcePort, destPort string) types.PacketData { | ||
| return types.PacketData{ | ||
| SourcePort: sourcePort, | ||
| DestinationPort: destPort, | ||
| Payload: types.Payload{ | ||
| Encoding: "json", | ||
| Value: mock.MockPacketData, | ||
| Version: mock.Version, | ||
| }, | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: i prefer calling this payload
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
atm we have
PacketDatawhich contains a payload, but I'm fine with calling the entire thing payload and not having a nested field at all. Might do this in a follow up since there are some other PRs working with this same type, will make an issue to track this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#7417