Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove fallback logic for GetChannel in timeout handler #7490

Merged
merged 2 commits into from
Oct 21, 2024
Merged

chore: remove fallback logic for GetChannel in timeout handler #7490

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
412219d
chore: remove fallback logic for GetChannel in timeout handler
Oct 21, 2024
f9650b8
Update modules/core/04-channel/v2/keeper/packet.go
Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions modules/core/04-channel/v2/keeper/packet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,11 +288,7 @@ func (k *Keeper) timeoutPacket(
// that the packet was indeed sent by our counterparty.
channel, ok := k.GetChannel(ctx, packet.SourceChannel)
if !ok {
// TODO: figure out how aliasing will work when more than one payload is sent.
channel, ok = k.convertV1Channel(ctx, packet.Payloads[0].SourcePort, packet.SourceChannel)
if !ok {
return errorsmod.Wrap(types.ErrChannelNotFound, packet.DestinationChannel)
}
return errorsmod.Wrap(types.ErrChannelNotFound, packet.DestinationChannel)
}
if channel.CounterpartyChannelId != packet.DestinationChannel {
return errorsmod.Wrapf(channeltypes.ErrInvalidChannelIdentifier, "counterparty channel id (%s) does not match packet destination channel id (%s)", channel.CounterpartyChannelId, packet.DestinationChannel)
Expand Down
Loading