Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR 002: Localhost Client #75

Closed
wants to merge 5 commits into from
Closed

ADR 002: Localhost Client #75

wants to merge 5 commits into from

Conversation

AdityaSripal
Copy link
Member

Labelled 02, since I think ADR 001 from the SDK should be ported here as its more relevant to IBC

docs/architecture/adr-002-local-host-client.md Outdated Show resolved Hide resolved
Comment on lines +27 to +30
The localhost implementation can remain unchanged, but now it will have access to the entire IBC store, and thus getting connections and channels using the paths specified by `24-host` will work as expected.

All of the special case code in the IBC client handlers can be removed as localhost will not have any separate state.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still a little confused. How do we implement these functions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we will still need to keep the begin blocker handler (to update latest height and chain id [in the case of an upgrade])

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fedekunze
Copy link
Contributor

should we merge this ADR?

@colin-axner
Copy link
Contributor

should we merge this ADR?

I was waiting on a response to this. It seems likely @AdityaSripal might not be the one to implement this ADR, so I think there should be a clarification on what to do in the instance I pointed out. I'd prefer not to leave parts of the implementation up to interpretation

@colin-axner colin-axner mentioned this pull request May 10, 2021
4 tasks
@colin-axner colin-axner marked this pull request as draft January 7, 2022 11:42
@colin-axner
Copy link
Contributor

I'm closing this. It is linked in the localhost issues, so it can be reopened if it becomes relevant again, but for now it seems this won't go anywhere (and isn't a priority at all)

@colin-axner colin-axner closed this Feb 3, 2022
faddat referenced this pull request in notional-labs/ibc-go Mar 1, 2022
Add simplystaking chain to testnet
@colin-axner colin-axner mentioned this pull request Mar 9, 2022
3 tasks
colin-axner pushed a commit that referenced this pull request Jul 28, 2022
@colin-axner colin-axner deleted the local-host-adr branch August 3, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants