-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADR 002: Localhost Client #75
Conversation
The localhost implementation can remain unchanged, but now it will have access to the entire IBC store, and thus getting connections and channels using the paths specified by `24-host` will work as expected. | ||
|
||
All of the special case code in the IBC client handlers can be removed as localhost will not have any separate state. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still a little confused. How do we implement these functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we will still need to keep the begin blocker handler (to update latest height and chain id [in the case of an upgrade])
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump @AdityaSripal
should we merge this ADR? |
I was waiting on a response to this. It seems likely @AdityaSripal might not be the one to implement this ADR, so I think there should be a clarification on what to do in the instance I pointed out. I'd prefer not to leave parts of the implementation up to interpretation |
I'm closing this. It is linked in the localhost issues, so it can be reopened if it becomes relevant again, but for now it seems this won't go anywhere (and isn't a priority at all) |
Add simplystaking chain to testnet
Applied self review suggestions
Labelled 02, since I think ADR 001 from the SDK should be ported here as its more relevant to IBC