refactor: remove simd from callbacks module #7506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
commented
Oct 22, 2024
There was a problem hiding this comment.
basically never used
colin-axner
commented
Oct 22, 2024
| @@ -7,17 +7,10 @@ replace github.com/cosmos/ibc-go/v9 => ../../../ | |||
| replace github.com/syndtr/goleveldb => github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7 | |||
|
|
|||
| require ( | |||
| cosmossdk.io/api v0.7.6 | |||
There was a problem hiding this comment.
9 deps just for binary building 😄
colin-axner
requested review from
AdityaSripal,
damiannolan,
srdtrk,
chatton,
DimitrisJim,
gjermundgaraba and
bznein
as code owners
DimitrisJim
approved these changes
Nov 11, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I thought about moving callbacks to top level simapp, but currently the simd built for it uses a
MockContractKeeper. Introducing it in the top level simapp would either need to rely on this (that seems pointless or x/wasmd which seems problematic)Given that there are no custom e2e's for callbacks. I propose we remove all this auxiliary code until it's needed (and in such case can be added to the top level simapp)
ref: #7231
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.