-
Notifications
You must be signed in to change notification settings - Fork 731
test: set expError for fake acknowledgement test case #8190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: set expError for fake acknowledgement test case #8190
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
We don't need to forward port this PR to v8.x or v10.x because the unit tests were refactored between v7.x and v8.x and v8.x and above already assert on the expected error |
a3ba334
into
cosmos:release/v7.10.x
|
Thank you for the PR 🙏 |
Context
https://celestia-team.slack.com/archives/C01BZ4XNGFK/p1741950351888399
cc: @gjermundgaraba
Problem
This PR added a test case for the most recent security vulnerability but the test case doesn't verify that the error is of type
types.ErrInvalidAcknowledgement