Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switching connectionID/portID in host module store key #834

Closed
wants to merge 1 commit into from

Conversation

seantking
Copy link
Contributor

Description

Follow up to: #823

I mistakenly left out some of the host modules' necessary updates.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@seantking seantking changed the title fix: switching connectionID/portID fix: switching connectionID/portID in host module store key Feb 2, 2022
@damiannolan
Copy link
Member

Isn't this duplicate code to #833?

@seantking seantking closed this Feb 2, 2022
@seantking
Copy link
Contributor Author

Isn't this duplicate code to #833?

Yes sorry. Brain bad. Thought I left out part of the KeyActiveChannel update by mixing up with the other PR.

@seantking seantking deleted the sean/fix-host-get-all-active-channel branch August 3, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants