Skip to content

Conversation

@jtieri
Copy link
Contributor

@jtieri jtieri commented May 30, 2025

Description

This PR adds amino encoding support to MsgRecoverClient so that txs that include this msg type can be signed via Ledger devices.

It would be great if these changes could get backported to v8 as well.

closes: #8447


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Include changelog entry when appropriate (e.g. chores should be omitted from changelog).
  • Wrote unit and integration tests if relevant.
  • Updated documentation (docs/) if anything is changed.
  • Added godoc comments if relevant.
  • Self-reviewed Files changed in the GitHub PR explorer.
  • Provide a conventional commit message to follow the repository standards.

@codecov
Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.80%. Comparing base (78b0abe) to head (e3e94b6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8448   +/-   ##
=======================================
  Coverage   56.79%   56.80%           
=======================================
  Files         299      299           
  Lines       21518    21521    +3     
=======================================
+ Hits        12222    12225    +3     
  Misses       8738     8738           
  Partials      558      558           
Flag Coverage Δ
08-wasm 66.13% <ø> (ø)
e2e 1.18% <ø> (ø)
ibc-go 62.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@gjermundgaraba gjermundgaraba enabled auto-merge (squash) June 5, 2025 16:21
@gjermundgaraba gjermundgaraba merged commit de2f70a into cosmos:main Jun 5, 2025
46 of 48 checks passed
mergify bot pushed a commit that referenced this pull request Jun 5, 2025
Co-authored-by: Gjermund Garaba <gjermund@garaba.net>
(cherry picked from commit de2f70a)

# Conflicts:
#	modules/core/02-client/types/codec.go
#	modules/core/02-client/types/tx.pb.go
mergify bot pushed a commit that referenced this pull request Jun 5, 2025
Co-authored-by: Gjermund Garaba <gjermund@garaba.net>
(cherry picked from commit de2f70a)
gjermundgaraba added a commit that referenced this pull request Jun 5, 2025
Co-authored-by: Gjermund Garaba <gjermund@garaba.net>
Co-authored-by: Justin Tieri <37750742+jtieri@users.noreply.github.com>
fix: support amino encoding on MsgRecoverClient (#8448)
gjermundgaraba added a commit that referenced this pull request Jun 19, 2025
Co-authored-by: Gjermund Garaba <gjermund@garaba.net>
Co-authored-by: Justin Tieri <37750742+jtieri@users.noreply.github.com>
Co-authored-by: Dan Kanefsky <56059752+boojamya@users.noreply.github.com>
fix: support amino encoding on MsgRecoverClient (#8448)
fix mergify conflicts in #8483 (#8549)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MsgRecoverClient does not support amino encoding

3 participants