-
Notifications
You must be signed in to change notification settings - Fork 731
fix: support amino encoding on MsgRecoverClient #8448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8448 +/- ##
=======================================
Coverage 56.79% 56.80%
=======================================
Files 299 299
Lines 21518 21521 +3
=======================================
+ Hits 12222 12225 +3
Misses 8738 8738
Partials 558 558
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AdityaSripal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Co-authored-by: Gjermund Garaba <gjermund@garaba.net> (cherry picked from commit de2f70a) # Conflicts: # modules/core/02-client/types/codec.go # modules/core/02-client/types/tx.pb.go
Co-authored-by: Gjermund Garaba <gjermund@garaba.net> (cherry picked from commit de2f70a)
Description
This PR adds amino encoding support to
MsgRecoverClientso that txs that include this msg type can be signed via Ledger devices.It would be great if these changes could get backported to v8 as well.
closes: #8447
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) if anything is changed.godoccomments if relevant.Files changedin the GitHub PR explorer.