Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: allow the mock module to be used multiple times as base ibc application in middleware stack #892

Merged
merged 9 commits into from
Feb 10, 2022
+39 −23
Merged

refactor: allow the mock module to be used multiple times as base ibc application in middleware stack #892

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
70e6a3a
refactor: allow the mock module to be used multiple times as base ibc…
colin-axner Feb 9, 2022
ba3d43d
add changelog entry
colin-axner Feb 9, 2022
174057e
update testing docs
colin-axner Feb 9, 2022
a78bc3f
chore: add and use 'NewMockIBCApp'
colin-axner Feb 9, 2022
aeb3d61
Merge branch 'main' into colin/ibcmock-improvements
colin-axner Feb 9, 2022
f330f34
Update CHANGELOG.md
colin-axner Feb 9, 2022
0b3d732
fix merge conflicts
colin-axner Feb 10, 2022
5c38780
fix merge conflicts
colin-axner Feb 10, 2022
662b5e7
Update CHANGELOG.md
colin-axner Feb 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update CHANGELOG.md
  • Loading branch information
@colin-axner
colin-axner authored Feb 10, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 662b5e7d680851b1d15c3fbdd23b0da47033d62e
1 change: 0 additions & 1 deletion CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -56,7 +56,6 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (testing) [\#892](https://github.com/cosmos/ibc-go/pull/892) IBC Mock modules store the scoped keeper and portID within the IBCMockApp. They also maintain reference to the AppModule to update the AppModule's list of IBC applications it references. Allows for the mock module to be reused as a base application in middleware stacks.
* (channel) [\#882](https://github.com/cosmos/ibc-go/pull/882) The `WriteAcknowledgement` API now takes `exported.Acknowledgement` instead of a byte array


### State Machine Breaking

* (transfer) [\#818](https://github.com/cosmos/ibc-go/pull/818) Error acknowledgements returned from Transfer `OnRecvPacket` now include a deterministic ABCI code and error message.