Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate the use of DomainType blanket implementation #15

Open
adizere opened this issue Nov 12, 2020 · 0 comments
Open

Investigate the use of DomainType blanket implementation #15

adizere opened this issue Nov 12, 2020 · 0 comments

Comments

@adizere
Copy link
Contributor

adizere commented Nov 12, 2020

Looking at this now and wondering why we need impl DomainType<RawMyType> for <MyType> for many of these. Just the TryFrom/From would be enough. The code compiles and runs fine if we remove all except the cases where RawMyType is not a prost message but wire bytes. For example the client state that is stuffed into an Any type as Vec, or merkle proofs.

(Note - the question is general not only for this PR. We have this pattern everywhere in the code)

Originally posted by @ancazamfir in informalsystems/hermes#391 (comment)

@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant