You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looking at this now and wondering why we need impl DomainType<RawMyType> for <MyType> for many of these. Just the TryFrom/From would be enough. The code compiles and runs fine if we remove all except the cases where RawMyType is not a prost message but wire bytes. For example the client state that is stuffed into an Any type as Vec, or merkle proofs.
(Note - the question is general not only for this PR. We have this pattern everywhere in the code)
Looking at this now and wondering why we need
impl DomainType<RawMyType> for <MyType>
for many of these. Just the TryFrom/From would be enough. The code compiles and runs fine if we remove all except the cases whereRawMyType
is not a prost message but wire bytes. For example the client state that is stuffed into anAny
type as Vec, or merkle proofs.(Note - the question is general not only for this PR. We have this pattern everywhere in the code)
Originally posted by @ancazamfir in informalsystems/hermes#391 (comment)
The text was updated successfully, but these errors were encountered: