-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICS 4 Domain Types for channel handshakes #391
Conversation
Merged with changes from latest master modifications: 12cb1d6#diff-a9dd86861adb60ba50e159c43913d6f20a5d406115a2ef4d17c7d0725054c7cc
Codecov Report
@@ Coverage Diff @@
## master informalsystems/hermes#391 +/- ##
=========================================
+ Coverage 13.6% 35.8% +22.1%
=========================================
Files 69 150 +81
Lines 3752 9499 +5747
Branches 1374 3424 +2050
=========================================
+ Hits 513 3403 +2890
- Misses 2618 5860 +3242
+ Partials 621 236 -385
Continue to review full report at Codecov.
|
Looking at this now and wondering why we need (Note - the question is general not only for this PR. We have this pattern everywhere in the code) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks Adi! Let's merge this and we'll make more changes as we implement the handlers (making use of the deserializer/ TryFrom
part) and the relayer (used the serializer/ From
part).
* First step towards #315 * Domain type & tests for chan_open_init. * Fix FMT * WIP ChannelOpenTry Domain type & tests * Re-adding ConnectionMsgType (accidentally removed). * Done with OpenTry msg * Finished ChanOpenAck domain type + tests; also fmt fix. * Finished ChanOpenConfirm message * ChanCloseInit done * FMT fix * Removed unnecessary derives. Close Confirm done * Rename packet into RecvPacket. Almost done. * Updated changelog
Closes: cosmos/ibc-rs#105
Description
For contributor use:
docs/
) and code comments.Files changed
in the Github PR explorer.