Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the channel message domain types #105

Closed
4 tasks done
ancazamfir opened this issue Oct 15, 2020 · 0 comments
Closed
4 tasks done

Implement the channel message domain types #105

ancazamfir opened this issue Oct 15, 2020 · 0 comments
Assignees
@adizere

Comments

@ancazamfir
Copy link
Collaborator

ancazamfir commented Oct 15, 2020 •
edited by adizere
Loading

Summary

ics04-channel module is incomplete wrt to domain type implementations

Proposal

[X] Add the From/TryFrom impls for all messages and supporting structures where missing
[X] Restructure the tests to initialize with raw messages and test (de)serialization
[X] Split the msgs.rs file in per message modules

Note: this does not include packet-related messages (e.g., timout, ack). https://github.com/informalsystems/ibc-rs/issues/95 is for that.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
This was referenced Oct 15, 2020
Closed
Closed
Closed
@adizere adizere self-assigned this Nov 2, 2020
adizere referenced this issue in informalsystems/hermes Nov 2, 2020
@adizere
First step towards #315
ce7a84a
@Shivani912 Shivani912 mentioned this issue Sep 29, 2022
Closed
This was referenced Sep 29, 2022
Closed
Closed
Closed
Merged
Merged
adizere referenced this issue in informalsystems/hermes Nov 11, 2020
@adizere
First step towards #315 (#394)
49129e5
adizere referenced this issue in informalsystems/hermes Nov 12, 2020
@adizere
ICS 4 Domain Types for channel handshakes (#391)
3abb563 
* First step towards #315

* Domain type & tests for chan_open_init.

* Fix FMT

* WIP ChannelOpenTry Domain type & tests

* Re-adding ConnectionMsgType (accidentally removed).

* Done with OpenTry msg

* Finished ChanOpenAck domain type + tests; also fmt fix.

* Finished ChanOpenConfirm message

* ChanCloseInit done

* FMT fix

* Removed unnecessary derives. Close Confirm done

* Rename packet into RecvPacket. Almost done.

* Updated changelog
hu55a1n1 referenced this issue in hu55a1n1/hermes Sep 13, 2022
@adizere
ICS 4 Domain Types for channel handshakes (informalsystems#391)
46662b7 
* First step towards #315

* Domain type & tests for chan_open_init.

* Fix FMT

* WIP ChannelOpenTry Domain type & tests

* Re-adding ConnectionMsgType (accidentally removed).

* Done with OpenTry msg

* Finished ChanOpenAck domain type + tests; also fmt fix.

* Finished ChanOpenConfirm message

* ChanCloseInit done

* FMT fix

* Removed unnecessary derives. Close Confirm done

* Rename packet into RecvPacket. Almost done.

* Updated changelog
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
livelybug pushed a commit to octopus-network/ibc-rs that referenced this issue Oct 14, 2022
@adizere
Merge pull request cosmos#105 from informalsystems/adi/main_readme
7a49bca 
Fixed top-level readme w/ more detailed guideline
shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this issue Nov 4, 2023
@romac
Merge pull request cosmos#105 from confio/release/v0.8.1
9c4e35d 
Rust: Release `ics23` version 0.8.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adizere adizere

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adizere @ancazamfir