Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prost: auto derive prost::Name #163

Merged
merged 5 commits into from
Nov 22, 2023
Merged

prost: auto derive prost::Name #163

merged 5 commits into from
Nov 22, 2023

Conversation

erwanor
Copy link
Collaborator

@erwanor erwanor commented Nov 21, 2023

Thanks to @tarcieri, the prost::Name trait is part of prost@0.12. We should use it!

This PR uses prost-build@0.12.3 to automatically derive the Name impl. It also modifies the proto compiler to patch the staking protos' ValidatorVec's implementation.

@redshiftzero redshiftzero mentioned this pull request Nov 21, 2023
Merged
2 tasks
romac
romac approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks so much!

@romac romac merged commit 8a4cd24 into main Nov 22, 2023
10 checks passed
@romac romac deleted the erwan/prost_build_names branch November 22, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erwanor @romac