Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump borsh to v1 #210

Merged
merged 3 commits into from
May 29, 2024
Merged

Bump borsh to v1 #210

merged 3 commits into from
May 29, 2024

Conversation

seanchen1991
Copy link
Contributor

Bump the borsh dependency to v1 in order to address this security alert in ibc-rs: https://github.com/cosmos/ibc-rs/security/dependabot/1

@seanchen1991 seanchen1991 requested a review from romac May 14, 2024 18:35
@seanchen1991
Copy link
Contributor Author

Hm, looks like there's an issue with a borsh dependency, toml_datetime:

error: failed to select a version for `toml_datetime`.
    ... required by package `toml_edit v0.21.0`
    ... which satisfies dependency `toml_edit = "^0.21.0"` of package `proc-macro-crate v3.0.0`
    ... which satisfies dependency `proc-macro-crate = "^3"` of package `borsh-derive v1.5.0`
    ... which satisfies dependency `borsh-derive = "~1.5.0"` of package `borsh v1.5.0`
    ... which satisfies dependency `borsh = "^1.5"` (locked to 1.5.0) of package `ibc-proto v0.44.0 (/Users/seanchen/Informal/ibc-proto-rs)`
versions that meet the requirements `^0.6.5` are: 0.6.5

all possible versions conflict with previously selected packages.

I'm not sure what needs to be updated in order to address this dependency mismatch.

@seanchen1991 seanchen1991 merged commit e2211d9 into main May 29, 2024
10 checks passed
@seanchen1991 seanchen1991 deleted the chore/bump-borsh branch May 29, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants