Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt code to the new Height def, in particular the epoch_number #110

Closed
4 tasks
ancazamfir opened this issue Sep 30, 2020 · 1 comment
Closed
4 tasks

Adapt code to the new Height def, in particular the epoch_number #110

ancazamfir opened this issue Sep 30, 2020 · 1 comment
Assignees
@ancazamfir

Comments

@ancazamfir
Copy link
Collaborator

Summary

Problem Definition

With the latest proto definitions all heights are of the followint type:
https://github.com/informalsystems/ibc-rs/blob/ec9dafb7af199cf4e3d83b60a4fb971009dc141f/proto/src/prost/ibc.client.rs#L68-L85

Currently the epoch_number is ignored and we deserialize into 0 on receive and use 0 when we serialize.

Proposal

Add new domain type Height and define operators like eq, lt, etc. Update the code to use this new type.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ancazamfir ancazamfir self-assigned this Sep 30, 2020
@greg-szabo
Copy link
Member

This is done in Tendermint-rs, you can use that. (We can add Ord and Eq traits, if needed.)

@ancazamfir ancazamfir mentioned this issue Oct 12, 2020
Merged
6 tasks
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
livelybug pushed a commit to octopus-network/ibc-rs that referenced this issue Oct 14, 2022
@milosevic
The first version of relayer algorithm. (cosmos#110)
76b97a5 
* The first version of relayer algorithm.

* Update algorithm based on Adi's suggestions

* Add error handling logic
shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this issue Nov 4, 2023
@dependabot
Bump minimatch from 3.0.4 to 3.1.2 in /js (cosmos#110)
980cfd4 
Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2.
- [Release notes](https://github.com/isaacs/minimatch/releases)
- [Commits](isaacs/minimatch@v3.0.4...v3.1.2)

---
updated-dependencies:
- dependency-name: minimatch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ancazamfir ancazamfir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ancazamfir @greg-szabo