You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Align testing across the handlers of ICS02 and ICS03; tentative strategy: test process as well as keep separately, then test dispatch by comparing its output to the ones of process and keep.
(primarily Romain) -> deferred to Cleaner context mocks (testing infrastructure for modules) #111
Summary of Bug
As a follow-up to #127, the short term plan for maturing the handlers is sketched below, in the order of their priority.
(Anca, Romain, Adi)
process
as well askeep
separately, then testdispatch
by comparing its output to the ones ofprocess
andkeep
.(primarily Romain) -> deferred to Cleaner context mocks (testing infrastructure for modules) #111
(primarily Anca) -- Migrate handlers to newer protobuf definitions informalsystems/hermes#226
(primarily Adi) -- Extend client context mock to support more realistic unit testing #114
(Romain) -- Cleanup Any* wrappers related code informalsystems/hermes#225
TryFromRaw
with the more standardTryFrom
, with the goal of removing the former, see e.g., ICS 03 msgs.rs(Adi) -- this was made obsolete by Greg's Removed TryFromRaw, implemented DomainType where needed informalsystems/hermes#252
We'll expand and document each point (except for the first one) in a separate full-fledged issue as needed.
For Admin Use
The text was updated successfully, but these errors were encountered: