Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement decoding into ConnectionId #123

Closed
greg-szabo opened this issue Jul 31, 2020 · 0 comments · Fixed by informalsystems/hermes#196
Closed

Implement decoding into ConnectionId #123

greg-szabo opened this issue Jul 31, 2020 · 0 comments · Fixed by informalsystems/hermes#196
Assignees
@andynog

Comments

@greg-szabo
Copy link
Member

greg-szabo commented Jul 31, 2020 •
edited
Loading

https://github.com/informalsystems/ibc-rs/blob/9c733d7af1ee7c2dee07086c24f2a94f4d169825/modules/src/ics02_client/client.rs#L12

I think at the query of client Connection ID, we should decode the incoming connection details into a Vec<ConnectionId> instead of just keeping them as strings.

The reason is that here, we should use a ConnectionId type for easy handling of ConnectionIDs.

https://github.com/informalsystems/ibc-rs/blob/9c733d7af1ee7c2dee07086c24f2a94f4d169825/relayer-cli/src/commands/query/client.rs#L292-L294
@andynog andynog self-assigned this Jul 31, 2020
andynog referenced this issue in informalsystems/hermes Aug 5, 2020
@andynog
Replaced Vec<String> with Vec<ConnectionId> #185
a2e693c
@andynog andynog mentioned this issue Aug 5, 2020
Merged
6 tasks
andynog referenced this issue in informalsystems/hermes Aug 7, 2020
@andynog
Fixing integration test #185
57c0787
andynog referenced this issue in informalsystems/hermes Aug 7, 2020
@andynog
Fixing fmt issue #185
8fd63ba
ancazamfir referenced this issue in informalsystems/hermes Aug 14, 2020
@andynog
Replaced Vec<String> with Vec<ConnectionId> (#196)
4bd67d7 
* Replaced Vec<String> with Vec<ConnectionId> #185

* Fixing integration test #185

* Fixing fmt issue #185

* Fixing missing import #196
hu55a1n1 referenced this issue in hu55a1n1/hermes Sep 13, 2022
@andynog
Replaced Vec<String> with Vec<ConnectionId> (informalsystems#196)
b18adec 
* Replaced Vec<String> with Vec<ConnectionId> #185

* Fixing integration test #185

* Fixing fmt issue #185

* Fixing missing import informalsystems#196
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
hu55a1n1 pushed a commit that referenced this issue Sep 29, 2022
@ebuchman
fix versions and update readme (#123)
33b3fe5 
* fix versions

* update readme

* semver link
livelybug pushed a commit to octopus-network/ibc-rs that referenced this issue Oct 14, 2022
@ebuchman
fix versions and update readme (cosmos#123)
50d6e66 
* fix versions

* update readme

* semver link
DaviRain-Su added a commit to octopus-network/ibc-rs that referenced this issue May 12, 2023
@DaviRain-Su
Add support for frozen client state (cosmos#123)
80acaa8
shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this issue Nov 4, 2023
@romac
ci: Enable code coverage for TypeScript version (cosmos#123)
1172e6a 
* Enable code coverage for TypeScript version

* Fix coverage job

* Fix labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andynog andynog

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replaced Vec<String> with Vec<ConnectionId> informalsystems/hermes
2 participants
@greg-szabo @andynog