Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The function parameters in ValidationContext should be references, while the functions in ExecutionContext should take ownership #319

Closed
plafer opened this issue Jan 3, 2023 · 0 comments · Fixed by #326
Closed

The function parameters in ValidationContext should be references, while the functions in ExecutionContext should take ownership #319

plafer opened this issue Jan 3, 2023 · 0 comments · Fixed by #326
Assignees
@plafer
Labels
A: good-first-issue Admin: good for newcomers O: code-hygiene Objective: aims to improve code hygiene

Comments

@plafer
Copy link
Contributor

plafer commented Jan 3, 2023

Analogous to #304 for ValidationContext and ExecutionContext.
@plafer plafer added A: good-first-issue Admin: good for newcomers O: code-hygiene Objective: aims to improve code hygiene labels Jan 3, 2023
@plafer plafer self-assigned this Jan 5, 2023
@plafer plafer mentioned this issue Jan 5, 2023
Merged
7 tasks
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Feb 2, 2023
@Farhad-Shabani Farhad-Shabani added this to the ADR05 milestone Feb 2, 2023
@Farhad-Shabani Farhad-Shabani moved this from 📥 To Do to ✅ Done in ibc-rs Feb 2, 2023
@Farhad-Shabani Farhad-Shabani added this to the Support Anoma's onboarding efforts milestone Feb 3, 2023
@plafer plafer mentioned this issue Feb 13, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plafer plafer

Labels
A: good-first-issue Admin: good for newcomers O: code-hygiene Objective: aims to improve code hygiene
Projects
ibc-rs
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup method parameters in ValidationContext and ExecutionContext cosmos/ibc-rs
2 participants
@plafer @Farhad-Shabani