Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PartialEq to IbcEvent #68

Closed
3 of 5 tasks
yito88 opened this issue Nov 5, 2021 · 0 comments
Closed
3 of 5 tasks

Add PartialEq to IbcEvent #68

yito88 opened this issue Nov 5, 2021 · 0 comments
Assignees
Labels
O: new-feature Objective: aims to add new feature

Comments

@yito88
Copy link
Contributor

yito88 commented Nov 5, 2021

Crate

ibc

Summary

For equality comparison of events, I'd like to add PartialEq to IbcEvent

Problem Definition

No PartialEq for IbcEvent

Proposal

Just add PartialEq to IbcEvent and each event of modules

Acceptance Criteria

IbcEvent can be compared, e.g.

    if expected_event == actual_event {
        ...
    }

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@romac romac added the O: new-feature Objective: aims to add new feature label Nov 6, 2021
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this issue Nov 4, 2023
Bump minimum supported Rust version to 1.51.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: new-feature Objective: aims to add new feature
Projects
None yet
Development

No branches or pull requests

2 participants