You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I want to call verification functions for connection and channel without messages handling.
Problem Definition
They are general functions and can be used not only for handling a message. These verification functions in connection and channel are private because ics03_connection::handler::verify and ics04_channel::handler::verify are not public. If they are public, we can use them without messages.
Proposal
Just insert pub for verify to ics03_connection::handler and ics04_channel::handler
Acceptance Criteria
We can call these verification functions from outside
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate milestone (priority) applied
Appropriate contributors tagged
Contributor assigned/self-assigned
The text was updated successfully, but these errors were encountered:
Hello,
Thanks for opening an issue! We can get this done fast.
It would be good if you could review the PR informalsystems/hermes#1204, even though this is a simple fix.
Crate
IBC
Summary
I want to call verification functions for connection and channel without messages handling.
Problem Definition
They are general functions and can be used not only for handling a message. These verification functions in
connection
andchannel
are private becauseics03_connection::handler::verify
andics04_channel::handler::verify
are not public. If they are public, we can use them without messages.Proposal
Just insert
pub
forverify
toics03_connection::handler
andics04_channel::handler
Acceptance Criteria
We can call these verification functions from outside
For Admin Use
The text was updated successfully, but these errors were encountered: