Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call verification functions from outside #77

Closed
5 tasks
yito88 opened this issue Jul 14, 2021 · 1 comment
Closed
5 tasks

Call verification functions from outside #77

yito88 opened this issue Jul 14, 2021 · 1 comment
Assignees

Comments

@yito88
Copy link
Contributor

yito88 commented Jul 14, 2021

Crate

IBC

Summary

I want to call verification functions for connection and channel without messages handling.

Problem Definition

They are general functions and can be used not only for handling a message. These verification functions in connection and channel are private because ics03_connection::handler::verify and ics04_channel::handler::verify are not public. If they are public, we can use them without messages.

Proposal

Just insert pub for verify to ics03_connection::handler and ics04_channel::handler

Acceptance Criteria

We can call these verification functions from outside


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere
Copy link
Contributor

adizere commented Jul 16, 2021

Hello,
Thanks for opening an issue! We can get this done fast.
It would be good if you could review the PR informalsystems/hermes#1204, even though this is a simple fix.

@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this issue Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants