Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs.rs build is failing #875

Closed
rnbguy opened this issue Sep 21, 2023 · 2 comments · Fixed by #876
Closed

docs.rs build is failing #875

rnbguy opened this issue Sep 21, 2023 · 2 comments · Fixed by #876
Assignees
Labels
A: bug Admin: something isn't working
Milestone

Comments

@rnbguy
Copy link
Collaborator

rnbguy commented Sep 21, 2023

Bug Summary

Failed docs.rs build: https://docs.rs/crate/ibc/0.45.0/builds/917198

[INFO] [stderr] error[E0422]: cannot find struct, variant or union type `LineColumn` in crate `proc_macro`
[INFO] [stderr]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/safe-proc-macro2-1.0.36/src/wrapper.rs:485:33
[INFO] [stderr]     |
[INFO] [stderr] 485 |                 let proc_macro::LineColumn { line, column } = s.start();
[INFO] [stderr]     |                                 ^^^^^^^^^^ not found in `proc_macro`
[INFO] [stderr]     |
[INFO] [stderr] help: consider importing one of these items
[INFO] [stderr]     |
[INFO] [stderr] 1   + use crate::LineColumn;
[INFO] [stderr]     |
[INFO] [stderr] 1   + use crate::fallback::LineColumn;
[INFO] [stderr]     |
[INFO] [stderr] help: if you import `LineColumn`, refer to it directly
[INFO] [stderr]     |
[INFO] [stderr] 485 -                 let proc_macro::LineColumn { line, column } = s.start();
[INFO] [stderr] 485 +                 let LineColumn { line, column } = s.start();
[INFO] [stderr]     |
[INFO] [stderr] 

Details

Rust removed proc_macro::LineColumn which is being used in safe-proc-macro2 (dependency to safe-regex) under span-locations feature.

Probably docsrs is building the dependencies with --all-features which breaks the build in recent nightlies.

The fix requires an update from safe-proc-macro2 > safe-regex.

Version

0.42.0-0.45.0

@rnbguy rnbguy added the A: bug Admin: something isn't working label Sep 21, 2023
@rnbguy rnbguy self-assigned this Sep 21, 2023
@rnbguy
Copy link
Collaborator Author

rnbguy commented Sep 21, 2023

issue opened at upstream repo
https://gitlab.com/leonhard-llc/safe-regex-rs/-/issues/2

@rnbguy
Copy link
Collaborator Author

rnbguy commented Sep 22, 2023

The other way to fix this issue is to replace safe-regex with regex crate without std feature.

... or refactor to avoid regex requirement completely.

@rnbguy rnbguy mentioned this issue Sep 22, 2023
7 tasks
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Sep 27, 2023
@Farhad-Shabani Farhad-Shabani moved this from 📥 To Do to 🏗️ In Progress in ibc-rs Sep 27, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in ibc-rs Sep 27, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.46.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants