Remove regex requirement #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #876 +/- ##
==========================================
- Coverage 68.36% 68.32% -0.05%
==========================================
Files 128 128
Lines 15833 15811 -22
==========================================
- Hits 10825 10803 -22
Misses 5008 5008
☔ View full report in Codecov by Sentry. |
soareschen
requested changes
Sep 25, 2023
| .position(|x| !x.is_numeric()) | ||
| .map(|index| coin_str.split_at(index)) | ||
| .filter(|(amount, denom)| !amount.is_empty() && !denom.is_empty()) | ||
| .filter(|(_, denom)| { |
There was a problem hiding this comment.
I think filter means that you will exclude the invalid characters, but the result would be valid. In the original case, invalid characters will cause the method to fail.
| .filter(|(amount, denom)| !amount.is_empty() && !denom.is_empty()) | ||
| .filter(|(_, denom)| { | ||
| !denom.contains(|x| { | ||
| !matches!(x, 'a'..='z' | 'A'..='Z' | '0'..='9' | '/' | ':' | '\\' | '.' | '_' | '-') |
There was a problem hiding this comment.
I think \\ was used as an escape for \, which is an escape for . in the original regex.
Yea. Tests are coming 🙂 I wanted to confirm the parsing logic before that. |
Farhad-Shabani
requested changes
Sep 27, 2023
Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com> Signed-off-by: Rano | Ranadeep <ranadip.bswas@gmail.com>
Farhad-Shabani
approved these changes
Sep 27, 2023
soareschen
approved these changes
Sep 27, 2023
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
* regex dep over safe-regex * new error variant * refactor regex use * coin parser wo regex * rm regex dep * fix incorrect conditions * add Coin::new * rm blackslash from valid charset * rewrite coin tests using rstest * fix broken test for denom with backslash * add name to testcases and add new tests * expect test panic message * addd tests with plus sign * update regex comment * simplify impl logic * implicit from_str * slash delim test * add changelog entry * version bump for ref link Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com> Signed-off-by: Rano | Ranadeep <ranadip.bswas@gmail.com> * refactor denom parsing * refactor tests without Coin::new * rm Coin::new * nit --------- Signed-off-by: Rano | Ranadeep <ranadip.bswas@gmail.com> Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #875
Description
safe_regexwhich is breaking our docsrs buildsPR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.