Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on tendermint-rpc in ibc crate #90

Closed
5 tasks
romac opened this issue Feb 9, 2021 · 0 comments
Closed
5 tasks

Remove dependency on tendermint-rpc in ibc crate #90

romac opened this issue Feb 9, 2021 · 0 comments
Assignees

Comments

@romac
Copy link
Member

romac commented Feb 9, 2021

Crate

abc

Summary

Remove dependency on tendermint-rpc in ibc crate by moving the get_all_events function into the relayer.

Problem Definition

The ibc crate should not imply a dependency on tendermint-rpc and all its transitive dependencies, especially since the function that introduces the dependency is only use in the ibc-relayer crate.

Proposal

  • Move get_all_events into ibc-relayer.
  • Make tendermint-rpc a test-only dependency.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@romac romac self-assigned this Feb 9, 2021
@romac romac changed the title modules: Remove dependency on tendermint-rpc Remove dependency on tendermint-rpc in ibc crate Feb 11, 2021
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this issue Nov 4, 2023
adds support for host functions to ics23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants