-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix upgrade path check #1298
Fix upgrade path check #1298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1298 +/- ##
========================================
Coverage 66.99% 66.99%
========================================
Files 226 227 +1
Lines 23267 23451 +184
========================================
+ Hits 15588 15712 +124
- Misses 7679 7739 +60 ☔ View full report in Codecov by Sentry. |
@Farhad-Shabani Thank you for sharing the issue. I'll try to fix it in this PR because I want to try the fixes with Namada. |
Awesome. Thank you, @yito88. |
a5b0d24
to
30fa654
Compare
Co-authored-by: Sean Chen <seanchen11235@gmail.com> Signed-off-by: Yuji Ito <yito88@users.noreply.github.com>
Co-authored-by: Sean Chen <seanchen11235@gmail.com> Signed-off-by: Yuji Ito <yito88@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for taking care of this @yito88!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fixes. 🙏
Just noticed the changelog missed. Do you mind @yito88 add the following. I don't have the permission.
|
Thank you for reviewing! I've added change logs. |
FYI: I've confirmed that an IBC client on Namada can be upgraded. |
* fix upgrade_path prefix * fix conversion * add more check * user-defined upgrade path * fix a test * Update ibc-clients/ics07-tendermint/src/client_state/common.rs Co-authored-by: Sean Chen <seanchen11235@gmail.com> Signed-off-by: Yuji Ito <yito88@users.noreply.github.com> * Update ibc-clients/ics07-tendermint/src/client_state/common.rs Co-authored-by: Sean Chen <seanchen11235@gmail.com> Signed-off-by: Yuji Ito <yito88@users.noreply.github.com> * fmt * disallow empty upgrade_path * remove unused import * add InvalidUpgradePath * add changelogs --------- Signed-off-by: Yuji Ito <yito88@users.noreply.github.com> Co-authored-by: Sean Chen <seanchen11235@gmail.com>
Closes: #1297
Closes: #1303
Description
PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.