Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: duplicate ibc-core to ibc-eureka-core #1369

Open
wants to merge 5 commits into
base: feat/ibc-eureka
Choose a base branch
from

Conversation

rnbguy
Copy link
Collaborator

@rnbguy rnbguy commented Oct 29, 2024

Closes: #1366

Description

For now, we decided to duplicate the ibc-core packages and rename to ibc-eureka-core and modify for eureka spec.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@rnbguy rnbguy added the O: eureka Objective: implement IBC Eureka label Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 26.23370% with 6054 lines in your changes missing coverage. Please review.

Project coverage is 56.03%. Comparing base (cdd4625) to head (70e5b63).

Files with missing lines Patch % Lines
...-eureka-core/ics04-channel/types/src/events/mod.rs 35.86% 515 Missing ⚠️
ibc-eureka-core/ics04-channel/types/src/channel.rs 0.00% 330 Missing ⚠️
...reka-core/ics03-connection/types/src/connection.rs 0.00% 292 Missing ⚠️
ibc-eureka-core/ics24-host/types/src/path.rs 63.59% 269 Missing ⚠️
ibc-eureka-core/ics02-client/types/src/events.rs 52.83% 191 Missing ⚠️
...reka-core/ics04-channel/src/handler/recv_packet.rs 0.00% 188 Missing ⚠️
...c-eureka-core/ics04-channel/src/handler/timeout.rs 0.00% 174 Missing ⚠️
ibc-eureka-core/ics04-channel/types/src/packet.rs 0.00% 163 Missing ⚠️
...core/ics03-connection/src/handler/conn_open_try.rs 0.00% 146 Missing ⚠️
...c-eureka-core/ics23-commitment/types/src/merkle.rs 0.00% 146 Missing ⚠️
... and 78 more
Additional details and impacted files
@@                 Coverage Diff                  @@
##           feat/ibc-eureka    #1369       +/-   ##
====================================================
- Coverage            66.84%   56.03%   -10.81%     
====================================================
  Files                  225      315       +90     
  Lines                22631    30838     +8207     
====================================================
+ Hits                 15127    17280     +2153     
- Misses                7504    13558     +6054     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnbguy rnbguy changed the title feat: duplicate ibc-core to ibc-eureka-core refactor: duplicate ibc-core to ibc-eureka-core Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: eureka Objective: implement IBC Eureka
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant