Rename ics context #247
Merged
Rename ics context #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
plafer
suggested changes
Nov 18, 2022
There was a problem hiding this comment.
Thank you again @DaviRain-Su!
Can we also rename the following:
Ics18Context->RelayerContextIcs26Envelope->MsgEnvelope- And the variants (e.g.
Ics2Msg->ClientMsg, ...)
- And the variants (e.g.
The only change left after this PR would be the directory names. However that's a really big breaking change (all imports will need to change); I think we should wait for #235 for that.
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Rename Ics26Context to RouterContext * Rename Ics20Context to TransferContext * Rename Ics20Keeper to TransferKepper, Ics20Reader to TransferReader * fix test * Create 245-rename-ics-context.md * fmt code * Rename Ics18Context to RelayerContext * Rename Ics25Envelop to MsgEnvelop and Rename it's variants * update .changelog * Rename Ics20Context to TokenTransferContext Signed-off-by: Davirain <davirain.yin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #245
Description
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.