Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ConnectionMsg variant connection{Try, Ack} Box Wrap #285

Merged
merged 4 commits into from
Dec 7, 2022

Conversation

DaviRain-Su
Copy link
Contributor

Closes: #258

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Base: 65.31% // Head: 64.84% // Decreases project coverage by -0.47% ⚠️

Coverage data is based on head (fbcd63a) compared to base (3464923).
Patch coverage: 52.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #285      +/-   ##
==========================================
- Coverage   65.31%   64.84%   -0.48%     
==========================================
  Files         125      126       +1     
  Lines       13210    13852     +642     
==========================================
+ Hits         8628     8982     +354     
- Misses       4582     4870     +288     
Impacted Files Coverage Δ
...s/ibc/src/clients/ics07_tendermint/host_helpers.rs 0.00% <ø> (ø)
crates/ibc/src/core/handler.rs 0.00% <0.00%> (ø)
crates/ibc/src/core/ics03_connection/msgs.rs 100.00% <ø> (ø)
crates/ibc/src/core/ics26_routing/handler.rs 91.11% <ø> (ø)
crates/ibc/src/core/ics26_routing/msgs.rs 0.99% <0.00%> (ø)
...rc/core/ics03_connection/handler/conn_open_init.rs 57.84% <15.68%> (-42.16%) ⬇️
crates/ibc/src/mock/context.rs 70.41% <23.35%> (-5.52%) ⬇️
crates/ibc/src/core/context.rs 32.07% <50.00%> (+22.50%) ⬆️
...core/ics03_connection/handler/conn_open_confirm.rs 77.50% <65.64%> (-22.50%) ⬇️
...src/core/ics03_connection/handler/conn_open_ack.rs 78.05% <66.87%> (-14.51%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@plafer
Copy link
Contributor

plafer commented Dec 6, 2022

Thank you again for the contribution!

Regarding the CI failure, could you make sure that the branch is up to date with main?

Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@plafer plafer merged commit 5267047 into cosmos:main Dec 7, 2022
@DaviRain-Su DaviRain-Su deleted the 258-remove-wrap-box branch December 8, 2022 01:49
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
* Remove ConnectionMsg variant connection{Try, Ack} Box Wrap

* Create 258-remove-connectionmsg-variant-box-wrap.md

* Update context.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConnectionMsg::ConnectionOpen{Try, Ack} should not wrap a Box
2 participants