Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misbehaviour for ValidationContext and ExecutionContext #290

Merged
merged 4 commits into from
Dec 12, 2022

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Dec 7, 2022

Closes: #281


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@plafer plafer requested a review from hu55a1n1 December 7, 2022 21:56
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Base: 64.84% // Head: 64.29% // Decreases project coverage by -0.55% ⚠️

Coverage data is based on head (0540958) compared to base (1394280).
Patch coverage: 2.34% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
- Coverage   64.84%   64.29%   -0.56%     
==========================================
  Files         126      126              
  Lines       13852    13971     +119     
==========================================
  Hits         8982     8982              
- Misses       4870     4989     +119     
Impacted Files Coverage Δ
crates/ibc/src/core/context.rs 32.07% <0.00%> (ø)
crates/ibc/src/core/ics02_client/client_state.rs 75.00% <ø> (ø)
...ibc/src/core/ics02_client/handler/update_client.rs 38.66% <ø> (+0.75%) ⬆️
...s/ibc/src/clients/ics07_tendermint/client_state.rs 45.69% <1.85%> (-2.39%) ⬇️
.../ibc/src/core/ics02_client/handler/misbehaviour.rs 53.77% <2.32%> (-35.29%) ⬇️
crates/ibc/src/mock/client_state.rs 76.33% <3.44%> (-7.55%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@hu55a1n1 hu55a1n1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I noticed that the misbehaviour execute handler is currently performing full verification so we must make sure to address this when we work on #173.

@hu55a1n1 hu55a1n1 mentioned this pull request Dec 12, 2022
12 tasks
@plafer plafer merged commit 7d128f7 into main Dec 12, 2022
@plafer plafer deleted the plafer/281-misbehaviour branch December 12, 2022 19:08
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
* misbehaviour: validate()

* Misbehaviour: execute

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement misbehaviour in {Execution,Validation}Context
2 participants