Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: include deserialization test for token transfer with no memo field #793

Merged
merged 2 commits into from
Jul 31, 2023
Merged

test: include deserialization test for token transfer with no memo field #793

merged 2 commits into from
Jul 31, 2023

Conversation

Farhad-Shabani
Copy link
Member

Closes: #792

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review July 28, 2023 18:05
@codecov
Copy link

codecov bot commented Jul 28, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.11% 🎉

Comparison is base (b6ad8ce) 71.22% compared to head (497f408) 71.33%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #793      +/-   ##
==========================================
+ Coverage   71.22%   71.33%   +0.11%     
==========================================
  Files         124      124              
  Lines       14790    14832      +42     
==========================================
+ Hits        10534    10581      +47     
+ Misses       4256     4251       -5
Files Changed Coverage Δ
crates/ibc/src/applications/transfer/packet.rs 96.66% <100.00%> (-1.52%) ⬇️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

plafer
plafer reviewed Jul 31, 2023
View reviewed changes
Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge after we release the new ibc-proto-rs and update the dependency here

@Farhad-Shabani Farhad-Shabani requested a review from plafer July 31, 2023 14:14
@plafer plafer merged commit 5b50da0 into main Jul 31, 2023
@plafer plafer deleted the farhad/include-no-memo-test branch July 31, 2023 14:27
yito88 added a commit to heliaxdev/cosmos-ibc-rs that referenced this pull request Jul 31, 2023
@yito88
update ibc-proto-rs for ibc-rs/cosmos#793
9db6892
dzmitry-lahoda pushed a commit to dzmitry-lahoda-forks/ibc-rs that referenced this pull request Aug 1, 2023
@Farhad-Shabani @dzmitry-lahoda
test: include deserialization test for token transfer with no memo fi…
8ff5204 
…eld (cosmos#793)

* test: include deserialization test for no memo condition

* deps: bump ibc-proto-rs version
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
@Farhad-Shabani
test: include deserialization test for token transfer with no memo fi…
7f91e3a 
…eld (#793)

* test: include deserialization test for no memo condition

* deps: bump ibc-proto-rs version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plafer plafer plafer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
ibc-rs
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Token transfer fails when no memo
2 participants
@Farhad-Shabani @plafer