Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify, structure versioning mechanism #269

Closed
cwgoes opened this issue Sep 17, 2019 · 1 comment · Fixed by #273
Closed

Clarify, structure versioning mechanism #269

cwgoes opened this issue Sep 17, 2019 · 1 comment · Fixed by #273
Assignees
@cwgoes
Labels
app Application layer. from-review Feedback / alterations from specification review. tao Transport, authentication, & ordering layer.
Milestone
IBC Specification...

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Sep 17, 2019 •
edited
Loading

  • Set of acceptable versions provided by handshake initiator
  • Specific version to use for connection/channel provided by handshake receiver
  • Version confirmed by handshake initiator

Open question: should channel versions be protocol-level, application-level, or both?
@cwgoes cwgoes added this to the IBC Specification 1.0.0-rc4 milestone Sep 17, 2019
@cwgoes cwgoes self-assigned this Sep 17, 2019
@cwgoes cwgoes changed the title Add specific version string Clarify versioning mechanism Sep 17, 2019
@cwgoes cwgoes added app Application layer. tao Transport, authentication, & ordering layer. from-review Feedback / alterations from specification review. labels Sep 17, 2019
@cwgoes cwgoes changed the title Clarify versioning mechanism Clarify, structure versioning mechanism Sep 17, 2019
@cwgoes cwgoes mentioned this issue Sep 19, 2019
Merged
@cwgoes
Copy link
Contributor Author

cwgoes commented Sep 19, 2019

I think this will lead to the following definitions in ICS 3:

  • compatibleVersions a constant list, in preference order
  • pickVersion a function to determine which version to select from a list of versions

ICS 4 might be left as application-level versioning for now.

cwgoes added a commit that referenced this issue Sep 20, 2019
@cwgoes
Clarify connection versioning (ref #269)
9f7f20c
cwgoes added a commit that referenced this issue Sep 20, 2019
@cwgoes
Merge PR #273: Remaining rc3 feedback in preparation for rc4
6ee3570 
* Rebuild PDF
* Separate commitment path (ref #258)
* Clarify connection versioning (ref #269)
* Note private store key flexibility (ref #145)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwgoes cwgoes

Labels
app Application layer. from-review Feedback / alterations from specification review. tao Transport, authentication, & ordering layer.
Projects
None yet
Milestone
IBC Specification 1.0.0-rc4
Development

Successfully merging a pull request may close this issue.

Remaining rc3 feedback in preparation for rc4 cosmos/ibc
1 participant
@cwgoes