Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICS-26: onChanOpenTry is called with the wrong channelIdentifier #908

Closed
plafer opened this issue Jan 11, 2023 · 1 comment
Closed

ICS-26: onChanOpenTry is called with the wrong channelIdentifier #908

plafer opened this issue Jan 11, 2023 · 1 comment
Labels
bug tao Transport, authentication, & ordering layer.

Comments

@plafer
Copy link
Contributor

plafer commented Jan 11, 2023

So IIUC, the error in the spec is now that onChanOpenTry is called with datagram.channelIdentifier, whereas it should be called with the channelIdentifier returned by chanOpenTry, right? Then, the correct way to do it would be to write the ChannelEnd to storage in ICS-26, as is done in ibc-go, right?

Originally posted by @plafer in #906 (comment)
@crodriguezvega crodriguezvega added tao Transport, authentication, & ordering layer. bug labels Mar 31, 2023
@crodriguezvega
Copy link
Contributor

Closed by #963.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug tao Transport, authentication, & ordering layer.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@plafer @crodriguezvega