ics04: remove unused version from init and try handlers
#963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
mpoke,
AdityaSripal,
cwgoes,
colin-axner and
angbrav
as code owners
crodriguezvega
commented
Apr 13, 2023
| @@ -432,16 +430,14 @@ function handleChanOpenInit(datagram: ChanOpenInit) { | |||
| datagram.order, | |||
| datagram.connectionHops, | |||
| datagram.portIdentifier, | |||
| datagram.channelIdentifier, | |||
There was a problem hiding this comment.
This was also not correct here since the channel identifier is generated in INIT by the handler and it's not in the datagram.
AdityaSripal
requested changes
May 30, 2023
AdityaSripal
reviewed
Jun 1, 2023
| datagram.counterpartyPortIdentifier, | ||
| datagram.counterpartyChannelIdentifier, | ||
| version // pass in version returned from callback | ||
| datagram.counterpartyChannelIdentifier |
There was a problem hiding this comment.
THis shouldn't exist on ChanOpenInit
| ) | ||
| version, err = module.onChanOpenInit( | ||
| datagram.order, | ||
| datagram.connectionHops, | ||
| datagram.portIdentifier, | ||
| datagram.channelIdentifier, | ||
| channelIdentifier, | ||
| datagram.counterpartyPortIdentifier, | ||
| datagram.counterpartyChannelIdentifier, |
AdityaSripal
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.