Upgrade refactor #1006
Merged
Upgrade refactor #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaSripal
requested review from
mpoke,
cwgoes,
colin-axner and
angbrav
as code owners
AdityaSripal
added a commit
that referenced
this pull request
Jul 27, 2023
* first pass at changes * progress * add confirm step * restore on timeout in ack * add set counterparty timeout in ack * fix docs * Upgrade refactor (#1006) * refactor and fix bugs * fix packet flushing logic * remove unnecessary states * cleanup documentation * add consideration * remove channel state and flush status references * fix try error handling * fix packet processing bug * change equality and reorder * address feedback: * break issue * fix timeout logic * refactor to simplify start flushing code * fix timeout logic * counterparty hops * more explicit equality check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.