Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICS 7: Tendermint Client #332

Merged
merged 18 commits into from
Jan 4, 2020
Merged

ICS 7: Tendermint Client #332

merged 18 commits into from
Jan 4, 2020

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Dec 10, 2019 •
edited
Loading

Ref #286
Closes #311
Closes #145
Closes #13
Ref #282; that will be a separate spec though.

  • Alter paths for non-conflicting human-readable prefixes, e.g. /consensusState/{client-identifier}

@cwgoes cwgoes added the tao Transport, authentication, & ordering layer. label Dec 10, 2019
@cwgoes cwgoes mentioned this pull request Dec 16, 2019
Merged
15 tasks
@cwgoes cwgoes marked this pull request as ready for review December 20, 2019 00:14
@cwgoes
Copy link
Contributor Author

cwgoes commented Dec 20, 2019

Not yet totally complete but ready for initial review.

@cwgoes cwgoes added the ready-for-review Pull requests which are ready for review. label Dec 20, 2019
@cwgoes cwgoes mentioned this pull request Dec 21, 2019
Closed
@cwgoes cwgoes mentioned this pull request Jan 2, 2020
Closed
fedekunze
fedekunze reviewed Jan 2, 2020
View reviewed changes
Copy link

@fedekunze fedekunze left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Some minor things:

  • Add link or ref to the tendermint docs (specifically to the consensus algorithm)
  • Add link or ref to the Tendermint light client (docs or implementation)

spec/ics-007-tendermint-client/README.md Show resolved Hide resolved
spec/ics-007-tendermint-client/README.md Outdated Show resolved Hide resolved
@fedekunze fedekunze mentioned this pull request Jan 3, 2020
Closed
4 tasks
@cwgoes cwgoes added this to the IBC 1.0.0-rc6 milestone Jan 4, 2020
@cwgoes cwgoes mentioned this pull request Jan 4, 2020
Closed
@cwgoes
Copy link
Contributor Author

cwgoes commented Jan 4, 2020

Merging, but more reviews are welcome anytime.

@cwgoes cwgoes merged commit 3b7b789 into master Jan 4, 2020
@cwgoes cwgoes deleted the cwgoes/ics-7-tendermint-client branch January 4, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

Assignees
No one assigned
Labels
ready-for-review Pull requests which are ready for review. tao Transport, authentication, & ordering layer.
Projects
None yet
Milestone
IBC 1.0.0-rc6
2 participants
@cwgoes @fedekunze