Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICS 23: Vector commitments #74

Merged
merged 23 commits into from
May 4, 2019
Merged

ICS 23: Vector commitments #74

merged 23 commits into from
May 4, 2019

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Apr 16, 2019 •
edited
Loading

Closes #57.

Defines a general vector commitment schema, including types and functions that must be defined.

@cwgoes cwgoes added tao Transport, authentication, & ordering layer. wip Issues or pull requests which are in progress. stage-draft labels Apr 16, 2019
@cwgoes cwgoes marked this pull request as ready for review April 25, 2019 14:52
@cwgoes cwgoes added ready-for-review Pull requests which are ready for review. and removed wip Issues or pull requests which are in progress. labels Apr 25, 2019
@cwgoes cwgoes added wip Issues or pull requests which are in progress. and removed ready-for-review Pull requests which are ready for review. labels Apr 25, 2019
gamarin2
gamarin2 reviewed Apr 25, 2019
View reviewed changes
Copy link

@gamarin2 gamarin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straightforward, few comments

spec/ics-23-standard-accumulator/README.md Outdated Show resolved Hide resolved
spec/ics-23-standard-accumulator/README.md Outdated Show resolved Hide resolved
spec/ics-23-standard-accumulator/README.md Outdated Show resolved Hide resolved
spec/ics-23-standard-accumulator/README.md Outdated Show resolved Hide resolved
spec/ics-23-standard-accumulator/README.md Outdated Show resolved Hide resolved
spec/ics-23-standard-accumulator/README.md Outdated Show resolved Hide resolved
spec/ics-23-standard-accumulator/README.md Outdated Show resolved Hide resolved
@cwgoes
Copy link
Contributor Author

cwgoes commented Apr 25, 2019 •
edited
Loading

@ValarDragon has convinced me that we should standardize on vector commitments.

I'll modify this accordingly.

@cwgoes cwgoes changed the title ICS 23: Standard accumulator ICS 23: Vector commitments Apr 25, 2019
@cwgoes cwgoes added ready-for-review Pull requests which are ready for review. and removed wip Issues or pull requests which are in progress. labels Apr 25, 2019
liamsi
liamsi approved these changes Apr 26, 2019
View reviewed changes
Copy link

@liamsi liamsi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left very few minor nits and comments. Thanks a lot for taking this over @cwgoes ❤️ And many thanks to @ValarDragon for the comments and clarifications in the issue!

@cwgoes
Copy link
Contributor Author

cwgoes commented May 4, 2019

Merging as a draft, future comments always welcome.

@cwgoes cwgoes merged commit 999c0d9 into master May 4, 2019
@cwgoes cwgoes deleted the cwgoes/ics-23-standard-accumulator branch May 4, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValarDragon ValarDragon ValarDragon left review comments

@gamarin2 gamarin2 gamarin2 left review comments

@liamsi liamsi liamsi approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@mossid mossid Awaiting requested review from mossid

Assignees
No one assigned
Labels
ready-for-review Pull requests which are ready for review. tao Transport, authentication, & ordering layer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICS 23: Standard accumulator
4 participants
@cwgoes @ValarDragon @liamsi @gamarin2