Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS29: Simplify sendPacket interface #751

Merged
merged 1 commit into from
May 23, 2022
Merged

ICS29: Simplify sendPacket interface #751

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions spec/app/ics-029-fee-payment/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,10 +376,22 @@ function writeAcknowledgement(
return ics4Wrapper.writeAcknowledgement(packet, ack_bytes)
}

// Fee Middleware sendPacket function just forwards message to ics-4 handler
function sendPacket(packet: Packet) {
// Fee Middleware sendPacket function just forwards data to ics-4 handler
function sendPacket(
capability: CapabilityKey,
sourcePort: Identifier,
sourceChannel: Identifier,
timeoutHeight: Height,
timeoutTimestamp: uint64,
data: bytes) {
// ics4Wrapper may be core IBC or higher-level middleware
return ics4Wrapper.sendPacket(packet)
return ics4Wrapper.sendPacket(
capability,
sourcePort,
sourceChannel,
timeoutHeight,
timeoutTimestamp,
data)
}
```

Expand Down