Put ClientState in provableStore and use it in connOpen{Try,Ack}
#802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix `packetAcknowledgementPath` - Use string interpolation with `sequence` variable to be consistent with the rest of the variables
| `verifyClientState` verifies a proof of the client state of the specified client stored on the target machine. | ||
|
|
||
| ```typescript | ||
| type verifyClientState = ( |
There was a problem hiding this comment.
Rather than adding this function to the specification, we should transition to using the generic verify membership methods. Though I suppose that can be done in a separate PR
There was a problem hiding this comment.
If you would like to open an issue describing specifically what's to be done, I'd be happy to take a stab at it in another PR
AdityaSripal
approved these changes
Jul 27, 2022
|
Please add a changelog entry |
|
@AdityaSripal Done! 5a4e0c8 |
I think he was referring to add an entry to https://github.com/cosmos/ibc/blob/main/CHANGELOG.md |
mpoke
approved these changes
Jul 29, 2022
Sounds good!
|
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #764
I wasn't sure where to define the
validateSelfClient()function. ibc-go puts it in the ICS-2 client keeper, with the Tendermint implementation. However,validateSelfClient()is a function that should be provided by the host, and so belongs in ICS-24 in my opinion. Since ICS-24 doesn't have any per-consensus-protocol sections, I opted for writing the generic declaration ofvalidateSelfClient()in a new "Client state validation" section, and provide the Tendermint implementation as an example. I'm open to better ideas on how to organize this.I faced another challenge. In ibc-go,
validateSelfClient()takes ansdk.Contextas parameter and compares the appropriate fields against the fields of theClientStatepassed in as argument. The most elegant way I found to abstract this use of thesdk.Contextis to require the hosts to implementwhich asks the host to "represent itself as a
ClientState". In the case of the sdk, this would be implemented by building theClientStatefrom the appropriate fields in thesdk.Context. My only concern with this abstraction is that it might confuse users, as theClientStateis a light client abstraction, not a host chain one. Hopefully, the example provided is enough to clear up any confusion. Again, I'm open to better ways of doing it!