feat: enable no_std support for pbjson
#158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #158 +/- ##
===========================================
+ Coverage 48.76% 65.32% +16.55%
===========================================
Files 24 7 -17
Lines 9900 3550 -6350
Branches 86 0 -86
===========================================
- Hits 4828 2319 -2509
+ Misses 4715 1231 -3484
+ Partials 357 0 -357
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
romac
approved these changes
Aug 10, 2023
|
If nobody objects, let's merge this on Tuesday next week (August 15th). |
This was referenced Aug 16, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #156
Background
This PR addresses the
no_stdcompatibility issue withserdefeature inibc-rs. This is caused by the recent implementation of ProtoJSON serialization and deserialization for theics23Protobuf definitions usingpbjson, and then re-exporting the ics23 type inibc-proto-rs. Some of our users by then (starting from IBC-rs v0.41.0) are experiencing compilation errors.To meet this immediate need and the lack of activity in the
pbjsoncrate for months, we have taken the initiative to featureno_stdsupport in theinformalsystems-pbjsoncrate and have it published.Before finalizing this change, I’d like to cross-check with @hdevalence to ensure this addition is in line with their systems too and maintain the expected behavior.
Subsequent PR in
ibc-proto-rs: cosmos/ibc-proto-rs#118Subsequent PR in
ibc-rs: cosmos/ibc-rs#790