This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
ibc v5 #105
Merged
ibc v5 #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
damiannolan
approved these changes
Aug 4, 2022
|
I can confirm that it passed all tests-- is there anything more you'd like me to try? |
6 tasks
| @@ -137,7 +138,9 @@ var ( | |||
| staking.AppModuleBasic{}, | |||
| mint.AppModuleBasic{}, | |||
| distr.AppModuleBasic{}, | |||
| gov.NewAppModuleBasic(getGovProposalHandlers()...), | |||
| gov.NewAppModuleBasic( | |||
| []govclient.ProposalHandler{paramsclient.ProposalHandler, distrclient.ProposalHandler, upgradeclient.LegacyProposalHandler, upgradeclient.LegacyCancelProposalHandler}, | |||
There was a problem hiding this comment.
nit: remove empty line.
| @@ -297,7 +299,7 @@ func New( | |||
|
|
|||
| // add keepers | |||
| app.AccountKeeper = authkeeper.NewAccountKeeper( | |||
| appCodec, keys[authtypes.StoreKey], app.GetSubspace(authtypes.ModuleName), authtypes.ProtoBaseAccount, maccPerms, | |||
| appCodec, keys[authtypes.StoreKey], app.GetSubspace(authtypes.ModuleName), authtypes.ProtoBaseAccount, maccPerms, sdk.Bech32MainPrefix, | |||
There was a problem hiding this comment.
Suggested change
| appCodec, keys[authtypes.StoreKey], app.GetSubspace(authtypes.ModuleName), authtypes.ProtoBaseAccount, maccPerms, sdk.Bech32MainPrefix, | |
| appCodec, keys[authtypes.StoreKey], app.GetSubspace(authtypes.ModuleName), authtypes.ProtoBaseAccount, maccPerms, sdk.GetConfig().GetBech32AccountAddrPrefix(), |
|
Merged. Many thanks! @faddat |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the interchain accounts demo, but it uses ibc v5 and cosmos-sdk v0.46.0