fix!: remove duplicate event emission (#2282)

* remove duplicate event emission * add changelog entry (cherry picked from commit 47b786a) # Conflicts: # x/ccv/provider/keeper/consumer_lifecycle.go
cosmos · Sep 20, 2024 · db91a40 · db91a40
1 parent 5eb6d8c
commit db91a40
Show file tree

Hide file tree

Showing 3 changed files with 664 additions and 3 deletions.
diff --git a/.changelog/unreleased/bug-fixes/2282-duplicate-events.md b/.changelog/unreleased/bug-fixes/2282-duplicate-events.md
@@ -0,0 +1,2 @@
+- Remove duplicate event emission on cached context.
+  ([\#2282](https://github.com/cosmos/interchain-security/pull/2282))
diff --git a/x/ccv/consumer/keeper/distribution.go b/x/ccv/consumer/keeper/distribution.go
@@ -34,9 +34,6 @@ func (k Keeper) EndBlockRD(ctx sdk.Context) {
 	if err := k.SendRewardsToProvider(cachedCtx); err != nil {
 		k.Logger(ctx).Error("attempt to sent rewards to provider failed", "error", err)
 	} else {
-		// The cached context is created with a new EventManager so we merge the event
-		// into the original context
-		ctx.EventManager().EmitEvents(cachedCtx.EventManager().Events())
 		// write cache
 		writeCache()
 	}