Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove legacy_ibc_testing folder #1003

Closed
wants to merge 15 commits into from
Closed

chore: remove legacy_ibc_testing folder #1003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a1fa0e2
wip remove legacy_ibc_testing
tbruyelle May 22, 2023
de1fbab
use ibctesting.DefaultTestingAppInit
tbruyelle May 23, 2023
1177115
use latest SendPacket API
tbruyelle May 23, 2023
6660142
fix access to StakingKeeper.UnbondingTime
tbruyelle May 31, 2023
f709e6e
replace ibcsimapp.CreateTestPubKeys by ibctesting.GenerateKeys
tbruyelle May 31, 2023
723f04c
wip: attempt to replace SentPackets
tbruyelle May 31, 2023
338696c
replace ReconstructPacket by ibctesting one
tbruyelle May 31, 2023
f31ea60
fix testing consumer genesis
tbruyelle Jun 5, 2023
e28ae8c
Disable ibctesting revision format
tbruyelle Jun 5, 2023
5857807
fix access to sent packets
tbruyelle Jun 7, 2023
42ab6d2
fix democracy genesis
tbruyelle Jun 7, 2023
acca623
use latest SendPacket API
tbruyelle Jun 7, 2023
429caf9
fix AddDemocracyConsumer with non-nil valset
tbruyelle Jun 9, 2023
f06495e
fix tests/differences
tbruyelle Jun 9, 2023
ae4a979
remove TODO
tbruyelle Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/consumer-democracy/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ import (
porttypes "github.com/cosmos/ibc-go/v7/modules/core/05-port/types"
ibchost "github.com/cosmos/ibc-go/v7/modules/core/exported"
ibckeeper "github.com/cosmos/ibc-go/v7/modules/core/keeper"
ibctestingcore "github.com/cosmos/interchain-security/legacy_ibc_testing/core"
ibctesting "github.com/cosmos/interchain-security/legacy_ibc_testing/testing"
ibctesting "github.com/cosmos/ibc-go/v7/testing"
ibctestingtypes "github.com/cosmos/ibc-go/v7/testing/types"
"github.com/gorilla/mux"
"github.com/rakyll/statik/fs"
"github.com/spf13/cast"
Expand Down Expand Up @@ -929,7 +929,7 @@ func (app *App) GetBaseApp() *baseapp.BaseApp {
}

// GetStakingKeeper implements the TestingApp interface.
func (app *App) GetStakingKeeper() ibctestingcore.StakingKeeper {
func (app *App) GetStakingKeeper() ibctestingtypes.StakingKeeper {
return app.ConsumerKeeper
}

Expand Down
8 changes: 5 additions & 3 deletions app/consumer-democracy/proposals_whitelisting_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,17 @@ package app_test
import (
"testing"

ibctesting "github.com/cosmos/ibc-go/v7/testing"
appConsumer "github.com/cosmos/interchain-security/app/consumer-democracy"
ibctesting "github.com/cosmos/interchain-security/legacy_ibc_testing/testing"
icstestingutils "github.com/cosmos/interchain-security/testutil/ibc_testing"
testutil "github.com/cosmos/interchain-security/testutil/integration"
"github.com/stretchr/testify/require"
)

func TestDemocracyGovernanceWhitelistingKeys(t *testing.T) {
chain := ibctesting.NewTestChain(t, ibctesting.NewCoordinator(t, 0),
icstestingutils.DemocracyConsumerAppIniter, "test")
_, valUpdates, _ := testutil.CreateValidators(t, 4)
ibctesting.DefaultTestingAppInit = icstestingutils.DemocracyConsumerAppIniter(valUpdates)
chain := ibctesting.NewTestChain(t, ibctesting.NewCoordinator(t, 0), "test")
paramKeeper := chain.App.(*appConsumer.App).ParamsKeeper
for paramKey := range appConsumer.LegacyWhitelistedParams {
ss, ok := paramKeeper.GetSubspace(paramKey.Subspace)
Expand Down
6 changes: 3 additions & 3 deletions app/consumer/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,9 @@ import (
porttypes "github.com/cosmos/ibc-go/v7/modules/core/05-port/types"
ibchost "github.com/cosmos/ibc-go/v7/modules/core/exported"
ibckeeper "github.com/cosmos/ibc-go/v7/modules/core/keeper"
ibctesting "github.com/cosmos/ibc-go/v7/testing"
ibctestingtypes "github.com/cosmos/ibc-go/v7/testing/types"
appparams "github.com/cosmos/interchain-security/app/params"
ibctestingcore "github.com/cosmos/interchain-security/legacy_ibc_testing/core"
ibctesting "github.com/cosmos/interchain-security/legacy_ibc_testing/testing"
"github.com/gorilla/mux"
"github.com/rakyll/statik/fs"
"github.com/spf13/cast"
Expand Down Expand Up @@ -735,7 +735,7 @@ func (app *App) GetBaseApp() *baseapp.BaseApp {
}

// GetStakingKeeper implements the TestingApp interface.
func (app *App) GetStakingKeeper() ibctestingcore.StakingKeeper {
func (app *App) GetStakingKeeper() ibctestingtypes.StakingKeeper {
return app.ConsumerKeeper
}

Expand Down
6 changes: 3 additions & 3 deletions app/provider/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ import (
ibchost "github.com/cosmos/ibc-go/v7/modules/core/exported"
ibckeeper "github.com/cosmos/ibc-go/v7/modules/core/keeper"
tendermint "github.com/cosmos/ibc-go/v7/modules/light-clients/07-tendermint"
ibctestingcore "github.com/cosmos/interchain-security/legacy_ibc_testing/core"
ibctesting "github.com/cosmos/interchain-security/legacy_ibc_testing/testing"
ibctesting "github.com/cosmos/ibc-go/v7/testing"
ibctestingtypes "github.com/cosmos/ibc-go/v7/testing/types"

dbm "github.com/cometbft/cometbft-db"
abci "github.com/cometbft/cometbft/abci/types"
Expand Down Expand Up @@ -820,7 +820,7 @@ func (app *App) GetBaseApp() *baseapp.BaseApp {
}

// GetStakingKeeper implements the TestingApp interface.
func (app *App) GetStakingKeeper() ibctestingcore.StakingKeeper {
func (app *App) GetStakingKeeper() ibctestingtypes.StakingKeeper {
return app.StakingKeeper
}

Expand Down
13 changes: 0 additions & 13 deletions legacy_ibc_testing/README.md
View file
Open in desktop

This file was deleted.

48 changes: 0 additions & 48 deletions legacy_ibc_testing/core/events.go
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions legacy_ibc_testing/core/expected_keepers.go
View file
Open in desktop

This file was deleted.

85 changes: 0 additions & 85 deletions legacy_ibc_testing/simapp/helpers/test_helpers.go
View file
Open in desktop

This file was deleted.

Loading