Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: merge main into feature branch with fixes #1038

Merged
merged 55 commits into from
Jun 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
dfa0058
build(deps): bump gaurav-nelson/github-action-markdown-link-check fro…
dependabot[bot] May 8, 2023
7d20393
chore: bump hermes (#921)
faddat May 11, 2023
2322e25
build(deps): bump github.com/spf13/cast from 1.5.0 to 1.5.1 (#961)
dependabot[bot] May 15, 2023
aba4eb7
refactor: adopt the errors module to reduce the changeset for 47 (#920)
faddat May 15, 2023
da06d17
fix!: prevent denom DOS (#931)
shaspitz May 15, 2023
11f5334
fix: all feature branches should have CI (#958)
faddat May 17, 2023
82980f8
fix!: consumer key prefix order to avoid complex migrations (#963)
shaspitz May 17, 2023
7785fa4
docs: update changelog to prep for v1.3.0 release (#953)
shaspitz May 17, 2023
8815834
fix: mitigate e2e tests relaying and non-determinism (#968)
MSalopek May 18, 2023
0a360c6
deps: bump cometbft to v0.34.28 (#906)
faddat May 22, 2023
89d6a7d
fix!: Remove panics on failure to send IBC packets (#876)
mpoke May 22, 2023
bdf299b
build(deps): bump github.com/stretchr/testify from 1.8.2 to 1.8.3 (#969)
dependabot[bot] May 22, 2023
23deaea
build(deps): bump slackapi/slack-github-action from 1.23.0 to 1.24.0 …
dependabot[bot] May 23, 2023
c952d94
refactor!: upgrade ICS imports to v2 (#974)
shaspitz May 25, 2023
9466b86
docs: update PR template to consider migrations (#976)
shaspitz May 25, 2023
502d2d3
fix: v2 imports proto go_package option (#978)
shaspitz May 26, 2023
e886855
fix: partially revert key assignment type safety PR (#980)
shaspitz May 26, 2023
73b4a07
docs: update top level readme for repo (#981)
shaspitz May 30, 2023
daa0e14
ci: makefile target for checking if protos are updated (#979)
shaspitz May 30, 2023
e78e641
build(deps): bump github.com/cosmos/ibc-go/v4 from 4.4.0 to 4.4.2 (#982)
dependabot[bot] May 30, 2023
deed467
build(deps): bump JamesIves/github-pages-deploy-action from 4.4.1 to …
dependabot[bot] May 30, 2023
eaa34dc
build(deps): bump github.com/stretchr/testify from 1.8.3 to 1.8.4 (#985)
dependabot[bot] May 31, 2023
9f2be6c
feat: v2 migrations (#975)
shaspitz Jun 1, 2023
1ec8148
docs: cleanup changelog for v2.0.0 on main (#988)
shaspitz Jun 1, 2023
9920121
chore: Hardcode golangci-lint version (#990)
p-offtermatt Jun 2, 2023
957ddf4
docs: Increase the validator set of cosmos hub to 180 from 175 (#999)
mmulji-ic Jun 8, 2023
a1e18d0
fix: proper consumer key prefix ordering (#991)
shaspitz Jun 8, 2023
e2ac974
feat: Remove consumer genesis migration on provider (#997)
shaspitz Jun 8, 2023
67b93a4
docs: Update reward-distribution.md (#994)
shaspitz Jun 9, 2023
274eea0
chore: update workflow re. issues and PRs (#1002)
mpoke Jun 12, 2023
1113ba4
docs(adr): ADR-007 pause unbonding period during equivocation proposa…
tbruyelle Jun 12, 2023
2b18b5e
docs: Add type prefix link to CONTRIBUTING.md (#1007)
mpoke Jun 12, 2023
93e45a5
chore: enable mergify (#1009)
mpoke Jun 13, 2023
281a7ca
Markdownlint (#907)
pysel Jun 13, 2023
8c2fc56
fix: limit vsc matured packets handled per endblocker (#1004)
shaspitz Jun 13, 2023
07be71a
feat: integrate cometmock (#989)
p-offtermatt Jun 14, 2023
669a33a
docs: Create adr-004-denom-dos-fixes.md (#934)
jtremback Jun 15, 2023
6ee8315
docs: Fix link to template (#1027)
p-offtermatt Jun 16, 2023
0b636da
feat!: Add DistributionTransmissionChannel to ConsumerAdditionProposa…
mpoke Jun 16, 2023
05c2dae
docs: ADR for throttle with retries (#1005)
shaspitz Jun 16, 2023
8c8e6a0
Add time and block advancement integration for CometMock (#1017)
p-offtermatt Jun 19, 2023
1f58139
Merge branch 'main' into feat/upgrade-ics-sdk47-ibc7
MSalopek Jun 19, 2023
e72303e
refactor: first batch of post-merge changes
MSalopek Jun 19, 2023
0e496c7
refactor: batch sovereign changes with v47
MSalopek Jun 19, 2023
85659f0
refactor: another batch of post-merge changes
MSalopek Jun 19, 2023
1aec51f
changes to go.mod
MSalopek Jun 19, 2023
6867075
refactor: final batch of changes post-merge
MSalopek Jun 19, 2023
7b11a5e
refactor: rebuild protos for v47
MSalopek Jun 19, 2023
109cccb
refactor: rebuild mocks for v47
MSalopek Jun 19, 2023
377f466
refactor: testing changes
MSalopek Jun 20, 2023
a250216
refactor: update proto tooling and rebuild protos
MSalopek Jun 20, 2023
b467817
lint: appease gosec
MSalopek Jun 20, 2023
25d36c5
chore: rm unused string from Makefile
MSalopek Jun 20, 2023
96ed974
chore: rm unused in makefile .phony
MSalopek Jun 20, 2023
b926a4d
temporarily disable proto-check to run automated tests
MSalopek Jun 20, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/ISSUE_TEMPLATE/epic-template.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,20 @@ about: Basic template for EPICs (used by the team)
labels: epic, needs-triage
---

# Problem
## Problem

<!-- Please write a concise 1-3 line problem. -->

# Closing criteria
## Closing criteria

<!-- Please write a satisfiable criteria for closing this issue. -->


# Problem details
## Problem details

<!-- Please describe the problem in all detail. -->

# Task list
## Task list

```[tasklist]
### Must have
Expand Down
16 changes: 15 additions & 1 deletion .github/ISSUE_TEMPLATE/feature-request.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: Feature Request
about: Create a proposal to request a feature
labels: enhancement, needs-triage
labels: enhancement, epic, needs-triage
---

<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺
Expand All @@ -26,6 +26,20 @@ Are there any disadvantages of including this feature? -->

<!-- Detailed description of requirements of implementation -->

## Task list

```[tasklist]
### Must have
- [ ] discuss proposal (if proposal rejected, close EPIC)
- [ ] create ADR (if ADR rejected, close EPIC)
- [ ] add sub-tasks needed to implement the proposed feature
```

```[tasklist]
### Nice to have
- [ ] add sub-tasks that are nice to have for the proposed feature
```

____

#### For Admin Use
Expand Down
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/issue-template.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@ v Before smashing the submit button please review the template.
v Please also ensure that this is not a duplicate issue :)
☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -->

# Problem
## Problem

<!-- Please write a concise 1-3 line problem. -->

# Closing criteria
## Closing criteria

<!-- Please write a satisfiable criteria for closing this issue. -->


# Problem details
## Problem details

<!-- Please describe the problem in all detail. -->
52 changes: 4 additions & 48 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,49 +1,5 @@
<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->
Please go the the `Preview` tab and select the appropriate sub-template:

## Description

Closes: #XXXX

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

* [ ] Included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
* [ ] Added `!` to the type prefix if API or client breaking change
* [ ] Targeted the correct branch (see [PR Targeting](https://github.com/cosmos/interchain-security/blob/main/CONTRIBUTING.md#pr-targeting))
* [ ] Provided a link to the relevant issue or specification
* [ ] Followed the guidelines for [building SDK modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules)
* [ ] Included the necessary unit and integration [tests](https://github.com/cosmos/interchain-security/blob/main/CONTRIBUTING.md#testing)
* [ ] Added a changelog entry to `CHANGELOG.md`
* [ ] Included comments for [documenting Go code](https://blog.golang.org/godoc)
* [ ] Updated the relevant documentation or specification
* [ ] Reviewed "Files changed" and left comments if necessary <!-- relevant if the changes are not obvious -->
* [ ] Confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

* [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
* [ ] confirmed `!` in the type prefix if API or client breaking change
* [ ] confirmed all author checklist items have been addressed
* [ ] reviewed state machine logic
* [ ] reviewed API design and naming
* [ ] reviewed documentation is accurate
* [ ] reviewed tests and test coverage
* [Production code](?expand=1&template=production.md) - for types `fix`, `feat`, and `refactor`.
* [Docs](?expand=1&template=docs.md) - for documentation changes.
* [Others](?expand=1&template=others.md) - for changes that do not affect production code.
48 changes: 48 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE/production.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
<!--
The production pull request template is for types feat, fix, or refactor.
-->

## Description

Closes: #XXXX

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

* [ ] Included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
* [ ] Added `!` to the type prefix if API or client breaking change
* [ ] Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
* [ ] Targeted the correct branch (see [PR Targeting](https://github.com/cosmos/interchain-security/blob/main/CONTRIBUTING.md#pr-targeting))
* [ ] Provided a link to the relevant issue or specification
* [ ] Followed the guidelines for [building SDK modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules)
* [ ] Included the necessary unit and integration [tests](https://github.com/cosmos/interchain-security/blob/main/CONTRIBUTING.md#testing)
* [ ] Added a changelog entry to `CHANGELOG.md`
* [ ] Included comments for [documenting Go code](https://blog.golang.org/godoc)
* [ ] Updated the relevant documentation or specification
* [ ] Reviewed "Files changed" and left comments if necessary <!-- relevant if the changes are not obvious -->
* [ ] Confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

* [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
* [ ] confirmed `!` in the type prefix if API or client breaking change
* [ ] confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
* [ ] confirmed all author checklist items have been addressed
* [ ] reviewed state machine logic
* [ ] reviewed API design and naming
* [ ] reviewed documentation is accurate
* [ ] reviewed tests and test coverage
10 changes: 10 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,15 @@ updates:
interval: weekly
target-branch: "main"
open-pull-requests-limit: 10
labels:
- dependencies

- package-ecosystem: gomod
directory: "/"
schedule:
interval: daily
target-branch: "release/v2.0.x"
# Only allow automated security-related dependency updates on release branches.
open-pull-requests-limit: 0
labels:
- dependencies
4 changes: 2 additions & 2 deletions .github/workflows/automated-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ jobs:
uses: actions/setup-go@v4
with:
go-version: "1.19" # The Go version to download (if necessary) and use.

# - name: Proto Check
# run: make proto-check
- name: Unit, integration and difference tests
run: go test ./...

- name: E2E tests
run: make test-e2e-short
1 change: 1 addition & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ on:
push:
branches:
- main
- feat/*
pull_request:
types: [opened, synchronize, reopened]
jobs:
Expand Down
15 changes: 10 additions & 5 deletions .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,18 @@ name: "CodeQL"

on:
push:
branches: [main]
branches:
- main
- feat/*

paths-ignore:
- 'legacy_ibc_testing'
- "legacy_ibc_testing"
pull_request:
branches: [main]
branches:
- main
- feat/*
paths-ignore:
- 'legacy_ibc_testing'
- "legacy_ibc_testing"
schedule:
# ┌───────────── minute (0 - 59)
# │ ┌───────────── hour (0 - 23)
Expand Down Expand Up @@ -62,4 +67,4 @@ jobs:
# make release

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v2
uses: github/codeql-action/analyze@v2
3 changes: 1 addition & 2 deletions .github/workflows/deploy-docs.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

name: Deploy docs
# This job builds and deploys documenation to github pages.
# It runs on every push to main with a change in the docs folder.
Expand Down Expand Up @@ -41,7 +40,7 @@ jobs:
make build-docs

- name: Deploy 🚀
uses: JamesIves/github-pages-deploy-action@v4.4.1
uses: JamesIves/github-pages-deploy-action@v4.4.2
with:
branch: gh-pages
folder: ~/output
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ on:
branches:
- master
- main
- feat/*
pull_request:
permissions:
contents: read
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/gosec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@ on:
push:
branches:
- main
- feat/*
pull_request:
branches:
- main
- feat/*
jobs:
tests:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nightly-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Notify Slack on failure
uses: slackapi/slack-github-action@v1.23.0
uses: slackapi/slack-github-action@v1.24.0
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK
Expand Down
4 changes: 4 additions & 0 deletions .markdownlint.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"MD036": false,
"MD013": false
}
20 changes: 20 additions & 0 deletions .mergify.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
defaults:
actions:
backport:
assignees:
- "{{ author }}"

queue_rules:
- name: default
conditions:
- "#approved-reviews-by>1"

pull_request_rules:
- name: Backport patches to the release/v2.0.x branch
conditions:
- base=main
- label=A:backport/v2.0.x
actions:
backport:
branches:
- release/v2.0.x
Loading