feat!: Add support for priority validators #2101

p-offtermatt · 2024-07-26T08:29:42Z

Description

Closes: #2030

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Included the correct type prefix in the PR title
Targeted the correct branch (see PR Targeting)
Provided a link to the relevant issue or specification
Reviewed "Files changed" and left comments if necessary
Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

Confirmed the correct type prefix in the PR title
Confirmed all author checklist items have been addressed
Confirmed that this PR does not change production code

p-offtermatt

This looks great so far. I left a few comments

proto/interchain_security/ccv/provider/v1/provider.proto

.changelog/unreleased/api-breaking/provider/xxxx-priority-validators.md

.changelog/unreleased/features/provider/xxxx-priority-validators.md

tests/e2e/steps_permissionless_ics.go

x/ccv/provider/keeper/grpc_query.go

x/ccv/provider/keeper/power_shaping.go

x/ccv/provider/keeper/power_shaping_test.go

x/ccv/provider/migrations/v8/migrations.go

…rs.md Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>

Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>

…dators.md Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>

…terchain-security into ph/priority-validators

…s.go

tests/e2e/steps_partial_set_security.go

.changelog/unreleased/api-breaking/provider/xxxx-priority-validators.md

tests/e2e/steps_partial_set_security.go

x/ccv/provider/keeper/power_shaping_test.go

…terchain-security into ph/priority-validators

x/ccv/provider/keeper/power_shaping.go

.changelog/unreleased/api-breaking/provider/2101-introduce-priority-validators.md

contrib/local-testnet.sh

Co-authored-by: Marius Poke <marius.poke@posteo.de>

…terchain-security into ph/priority-validators

x/ccv/provider/client/cli/tx.go

x/ccv/provider/keeper/grpc_query_test.go

x/ccv/provider/keeper/power_shaping_test.go

bermuell

pls address comments

mpoke

Great work @p-offtermatt and @kirdatatjana. See my comments below.

docs/docs/adrs/adr-019-permissionless-ics.md

docs/docs/build/modules/02-provider.md

x/ccv/provider/client/cli/tx.go

mpoke · 2024-10-25T13:18:04Z

x/ccv/provider/client/legacy_proposals.go

@@ -43,6 +43,7 @@ type ConsumerAdditionProposalJSON struct {
 	Denylist           []string `json:"denylist"`
 	MinStake           uint64   `json:"min_stake"`
 	AllowInactiveVals  bool     `json:"allow_inactive_vals"`
+	Prioritylist       []string `json:"prioritylist"`


Do not update legacy proposals as we no longer need them. Actually, why do we even have this file?

Priority list is now removed from legacy_proposals.go.

@MSalopek do you know why do we still need this file? cc @bermuell

My mistake, the priority list is needed in legacy proposal for e2e test.

Why do we still legacy props on our e2e tests? Can we get rid of these? Not something we need to do in this PR though.

Don't remove them because you'll break governance on gaia. They have to exist so old Txs can be displayed and handled properly. Otherwise you will not be able to fetch an old block or check an old gov proposal because the gov type is missing.

Please don't remove it.

x/ccv/provider/client/legacy_proposals.go

x/ccv/provider/keeper/power_shaping.go

p-offtermatt added 2 commits July 26, 2024 10:28

Start adding priority validators

536243a

Add new priority_validator field

7b7612e

github-actions bot added the C:x/provider Assigned automatically by the PR labeler label Jul 26, 2024

kirdatatjana added 2 commits October 7, 2024 09:58

Resolve conflicts with main

c3df006

Added priority list to the PowerShapingParameters

f96fb22

github-actions bot added the C:Testing Assigned automatically by the PR labeler label Oct 15, 2024

Add documentation for priority list

e41bd64

github-actions bot added C:Docs Assigned automatically by the PR labeler C:ADR Assigned automatically by the PR labeler labels Oct 16, 2024

Add priority list in local-testnet.sh

5893cd3

p-offtermatt commented Oct 16, 2024

View reviewed changes

kirdatatjana and others added 10 commits October 16, 2024 09:56

Update .changelog/unreleased/features/provider/xxxx-priority-validato…

09beb73

…rs.md Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>

Update x/ccv/provider/keeper/power_shaping.go

d442765

Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>

Update x/ccv/provider/keeper/power_shaping_test.go

e6b17ef

Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>

Update x/ccv/provider/keeper/power_shaping_test.go

4083463

Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>

Update .changelog/unreleased/api-breaking/provider/xxxx-priority-vali…

508aa1c

…dators.md Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>

Fix typo in provider.proto

da41d15

Merge branch 'ph/priority-validators' of https://github.com/cosmos/in…

a7572eb

…terchain-security into ph/priority-validators

Remove unnecessary priority list from test in steps_permissionless_ic…

165ef87

…s.go

Remove comment from grpc_query.go

d5cb420

Add e2e test for priority list

b6788e6

p-offtermatt commented Oct 17, 2024

View reviewed changes

tests/e2e/steps_partial_set_security.go Outdated Show resolved Hide resolved

p-offtermatt commented Oct 17, 2024

View reviewed changes

tests/e2e/steps_partial_set_security.go Outdated Show resolved Hide resolved

kirdatatjana and others added 3 commits October 17, 2024 15:14

Improved e2e test

1c19591

Merge branch 'main' into ph/priority-validators

b36e28f

Merge branch 'main' into ph/priority-validators

171246d

kirdatatjana marked this pull request as ready for review October 17, 2024 13:48

kirdatatjana requested a review from a team as a code owner October 17, 2024 13:48

insumity reviewed Oct 21, 2024

View reviewed changes

.changelog/unreleased/api-breaking/provider/xxxx-priority-validators.md Outdated Show resolved Hide resolved

insumity reviewed Oct 21, 2024

View reviewed changes

tests/e2e/steps_partial_set_security.go Outdated Show resolved Hide resolved

p-offtermatt commented Oct 23, 2024

View reviewed changes

x/ccv/provider/keeper/power_shaping_test.go Show resolved Hide resolved

p-offtermatt commented Oct 23, 2024

View reviewed changes

x/ccv/provider/keeper/power_shaping_test.go Outdated Show resolved Hide resolved

kirdatatjana added 2 commits October 23, 2024 23:21

Refactored TestCapValidatorSet

2c83503

Merge branch 'ph/priority-validators' of https://github.com/cosmos/in…

a78038f

…terchain-security into ph/priority-validators

insumity reviewed Oct 24, 2024

View reviewed changes

kirdatatjana added 2 commits October 24, 2024 15:14

Small fixes

5ef9ff2

Small fixes

ba04ab8

insumity reviewed Oct 24, 2024

View reviewed changes

x/ccv/provider/keeper/power_shaping.go Outdated Show resolved Hide resolved

insumity approved these changes Oct 24, 2024

View reviewed changes

Fix PartitionBasedOnPriorityList function

d5d043b

mpoke changed the title ~~feat: Add support for priority validators~~ feat!: Add support for priority validators Oct 25, 2024

mpoke reviewed Oct 25, 2024

View reviewed changes

.changelog/unreleased/api-breaking/provider/2101-introduce-priority-validators.md Outdated Show resolved Hide resolved

contrib/local-testnet.sh Outdated Show resolved Hide resolved

kirdatatjana and others added 3 commits October 25, 2024 14:59

Update contrib/local-testnet.sh

31e8001

Co-authored-by: Marius Poke <marius.poke@posteo.de>

Moved 2101-introduce-priority-validators.md into state-breaking

cc84d75

Merge branch 'ph/priority-validators' of https://github.com/cosmos/in…

6336f9d

…terchain-security into ph/priority-validators

bermuell requested changes Oct 25, 2024

View reviewed changes

x/ccv/provider/client/cli/tx.go Outdated Show resolved Hide resolved

x/ccv/provider/client/cli/tx.go Outdated Show resolved Hide resolved

x/ccv/provider/keeper/grpc_query_test.go Outdated Show resolved Hide resolved

x/ccv/provider/keeper/power_shaping_test.go Show resolved Hide resolved

bermuell requested changes Oct 25, 2024

View reviewed changes

kirdatatjana added 2 commits October 25, 2024 15:11

Fixed TestGetConsumerChain

adc3a0e

Added test case in TestCapValidatorSet

94eba83

mpoke reviewed Oct 25, 2024

View reviewed changes

kirdatatjana added 4 commits October 25, 2024 15:39

Revert changes made by the merge

a49866c

Removed changes from ADRs that were already implemented

0b38ed4

Added a comment in CapValidatorSet function

a1d974d

Removed unnecessary imports

9f4d771

mpoke approved these changes Oct 25, 2024

View reviewed changes

bermuell approved these changes Oct 25, 2024

View reviewed changes

mpoke added this pull request to the merge queue Oct 25, 2024

Merged via the queue into main with commit dd09294 Oct 25, 2024
21 checks passed

mpoke deleted the ph/priority-validators branch October 25, 2024 16:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: Add support for priority validators #2101

feat!: Add support for priority validators #2101

p-offtermatt commented Jul 26, 2024

p-offtermatt left a comment

bermuell left a comment

mpoke left a comment

mpoke Oct 25, 2024

kirdatatjana Oct 25, 2024

mpoke Oct 25, 2024

kirdatatjana Oct 25, 2024

mpoke Oct 25, 2024

MSalopek Oct 25, 2024

feat!: Add support for priority validators #2101

feat!: Add support for priority validators #2101

Conversation

p-offtermatt commented Jul 26, 2024

Description

Author Checklist

Reviewers Checklist

p-offtermatt left a comment

Choose a reason for hiding this comment

bermuell left a comment

Choose a reason for hiding this comment

mpoke left a comment

Choose a reason for hiding this comment

mpoke Oct 25, 2024

Choose a reason for hiding this comment

kirdatatjana Oct 25, 2024

Choose a reason for hiding this comment

mpoke Oct 25, 2024

Choose a reason for hiding this comment

kirdatatjana Oct 25, 2024

Choose a reason for hiding this comment

mpoke Oct 25, 2024

Choose a reason for hiding this comment

MSalopek Oct 25, 2024

Choose a reason for hiding this comment