Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add e2e tests for permissionless ICS #2223

Merged
merged 2 commits into from
Sep 9, 2024
Merged

test: Add e2e tests for permissionless ICS #2223

merged 2 commits into from
Sep 9, 2024

Conversation

bermuell
Copy link
Contributor

@bermuell bermuell commented Sep 5, 2024 •
edited
Loading

Description

Add basic e2e tests for permissionless ICS
Change e2e tests to allow chain configurations with same ChainID

Limitation:
Current hermes version does not support two chains with same 'ChainID'. Therefore the tests Initializes two
chains with same ChainID and launches only one of them.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@bermuell bermuell self-assigned this Sep 5, 2024
@github-actions github-actions bot added the C:Testing Assigned automatically by the PR labeler label Sep 5, 2024
@bermuell bermuell force-pushed the bernd/permissionless_new_e2e branch 3 times, most recently from 22190a4 to 82c4bb3 Compare September 9, 2024 08:19
@github-actions github-actions bot added C:x/consumer Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler C:x/types Assigned automatically by the PR labeler C:Build Assigned automatically by the PR labeler C:CI Assigned automatically by the PR labeler C:Docs Assigned automatically by the PR labeler C:ADR Assigned automatically by the PR labeler C:x/democracy Assigned automatically by the PR labeler labels Sep 9, 2024
@bermuell bermuell changed the base branch from feat/permissionless to main September 9, 2024 08:20
@bermuell bermuell force-pushed the bernd/permissionless_new_e2e branch 3 times, most recently from 2d24a03 to f8b7f2b Compare September 9, 2024 09:59
@bermuell bermuell marked this pull request as ready for review September 9, 2024 11:25
@bermuell bermuell requested a review from a team as a code owner September 9, 2024 11:25
MSalopek
MSalopek approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@MSalopek MSalopek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

We can confirm that haing 2 chains with same chain-id does not break ICS through less costly tests. Now that we have that case added to e2e we should keep it.

EDIT:
I would add steps that transition a chain from opt-in to topN via a gov proposal.

@bermuell bermuell added this pull request to the merge queue Sep 9, 2024
Merged via the queue into main with commit c7171b2 Sep 9, 2024
14 of 15 checks passed
@bermuell bermuell deleted the bernd/permissionless_new_e2e branch September 9, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSalopek MSalopek MSalopek approved these changes

@insumity insumity insumity approved these changes

Assignees

@bermuell bermuell

Labels
C:ADR Assigned automatically by the PR labeler C:Build Assigned automatically by the PR labeler C:CI Assigned automatically by the PR labeler C:Docs Assigned automatically by the PR labeler C:Testing Assigned automatically by the PR labeler C:x/consumer Assigned automatically by the PR labeler C:x/democracy Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler C:x/types Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bermuell @insumity @MSalopek