fix!: remove duplicate event emission (backport #2282)

.changelog/unreleased/bug-fixes/2282-duplicate-events.md

@@ -0,0 +1,2 @@
+- Remove duplicate event emission on cached context.
+ ([\#2282](https://github.com/cosmos/interchain-security/pull/2282))

x/ccv/consumer/keeper/distribution.go

@@ -34,9 +34,6 @@ func (k Keeper) EndBlockRD(ctx sdk.Context) {
  if err := k.SendRewardsToProvider(cachedCtx); err != nil {
  k.Logger(ctx).Error("attempt to sent rewards to provider failed", "error", err)
  } else {
- // The cached context is created with a new EventManager so we merge the event
- // into the original context
- ctx.EventManager().EmitEvents(cachedCtx.EventManager().Events())
  // write cache
  writeCache()
  }

x/ccv/provider/keeper/proposal.go

@@ -461,9 +461,6 @@ func (k Keeper) BeginBlockInit(ctx sdk.Context) {
  continue
  }
 
- // The cached context is created with a new EventManager so we merge the event
- // into the original context
- ctx.EventManager().EmitEvents(cachedCtx.EventManager().Events())
  // write cache
  writeFn()
 
@@ -589,15 +586,13 @@ func (k Keeper) BeginBlockCCR(ctx sdk.Context) {
 
  for _, prop := range propsToExecute {
  // stop consumer chain in a cached context to handle errors
- cachedCtx, writeFn, err := k.StopConsumerChainInCachedCtx(ctx, prop)
+ _, writeFn, err := k.StopConsumerChainInCachedCtx(ctx, prop)
  if err != nil {
  // drop the proposal
  ctx.Logger().Info("consumer chain could not be stopped: %w", err)
  continue
  }
- // The cached context is created with a new EventManager so we merge the event
- // into the original context
- ctx.EventManager().EmitEvents(cachedCtx.EventManager().Events())
+
  // write cache
  writeFn()