Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove StakingHooksTemplate from provider hooks #389

Merged
merged 5 commits into from
Oct 25, 2022
Merged

Remove StakingHooksTemplate from provider hooks #389

merged 5 commits into from
Oct 25, 2022

Conversation

sainoe
Copy link
Contributor

@sainoe sainoe commented Oct 12, 2022

Change the provider hooks to not use a StakingHooksTemplate struct since it was deleted in the IS-SDK merge.

mpoke
mpoke approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danwt
Copy link
Contributor

danwt commented Oct 17, 2022 •
edited
Loading

I think we should hold approval of this until we know if we should already be pointing at the upstream changes

jtremback
jtremback approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@jtremback jtremback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtremback
Copy link
Contributor

I think we should hold approval of this until we know if we should already be pointing at the upstream changes

This works regardless, right?

@mpoke
Copy link
Contributor

mpoke commented Oct 20, 2022

@danwt Are we ready to merge this?

@danwt
Copy link
Contributor

danwt commented Oct 25, 2022

Ah yeah should be fine

@mpoke mpoke merged commit 22bc310 into main Oct 25, 2022
@mpoke mpoke deleted the sainoe/format-staking-hooks branch October 25, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpoke mpoke mpoke approved these changes

@jtremback jtremback jtremback approved these changes

@danwt danwt Awaiting requested review from danwt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use expected_keepers for staking hooks
4 participants
@sainoe @danwt @jtremback @mpoke